Bug 2337 - consolidate fines cronjobs into one program
Summary: consolidate fines cronjobs into one program
Status: CLOSED WONTFIX
Alias: None
Product: Koha
Classification: Unclassified
Component: Command-line Utilities (show other bugs)
Version: Main
Hardware: PC All
: P3 blocker (vote)
Assignee: Galen Charlton
QA Contact:
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-07-10 11:51 UTC by Chris Cormack
Modified: 2020-04-20 10:44 UTC (History)
1 user (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Cormack 2010-05-21 00:50:01 UTC


---- Reported by Andrew.moore@liblime.com 2008-07-10 11:51:10 ----

As part of my mail to koha-devel on June 4, I plan to reorganize the misc/cronjobs/fines*.pl scripts.
http://www.nabble.com/RFC%3A-plan-to-reorganize-cronjobs-for-overdues%2C-notices%2C-and-fines-to17651967.html

This consists of these items:

fines2.pl will get replaced by fines.pl
fines-ll.pl  will get folded into fines.pl. This script has good
calculation stuff that should be salvaged.
fines-sanop.pl will most likely be replaced by fines.pl.

as well as fixing a handful of outstanding bugs against these scripts. Notable among those are: 

http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=2013: New Overdues.pm breaks fines2.pl
http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=2182: Overdue Items list dates in European format
http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=1729: Change the way patron fines are displayed by boraccount.pl
and others.

I plan on starting this work immediately. I'm not sure of the schedule for 3.0, and I haven't taken much time to estimate how long this will take, so I don't know what version it will make it into.



---- Additional Comments From Andrew.moore@liblime.com 2008-07-14 13:40:16 ----

I need to make sure I take into account the information in http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=2013.



---- Additional Comments From Andrew.moore@liblime.com 2008-07-16 13:13:54 ----

I spoke with kados at all on #liblime for a while. It looks like we made the following decisions:

* fines.pl should mark items as lost. This will render longlost.pl as unnecssary. I'll delete is part of this.
* I'll have to add a few knobs to the overdue notices page to let people decide at which step to set items as lost. Looks like I may be killing but 1890 with this, too.
* we don't need to be able to configure the output csv file yet.

I think I have all of the design information that I'll need. I can get this written pretty quickly now. Perhaps I'll have a rough draft tomorrow afternoon.



---- Additional Comments From Andrew.moore@liblime.com 2008-07-17 09:06:28 ----

Sounds like this might take care of http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=1890, too.



---- Additional Comments From Andrew.moore@liblime.com 2008-07-22 08:53:14 ----

on a conference call today, it was pointed out to me that fines-ll.pl contains a lot of stuff that should probably not be in there:

* I think the calls to debar patrons may not be best in this script.
* the UpdateAccountLines should probably be moved to the overdues script. I don't really understand that, though.

We've identified something more urgent for me to be working on, so I'm laying this aside for some time.




---- Additional Comments From Andrew.moore@liblime.com 2008-07-23 13:43:27 ----

In my discussion yesterday with Debra, Ryan, and Galen, we decided that there doesn't actually need to be any changes made to these scripts, so I'm abandoning this work. I guess I'll close the ticket.




--- Bug imported by chris@bigballofwax.co.nz 2010-05-21 00:50 UTC  ---

This bug was previously known as _bug_ 2337 at http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=2337

Actual time not defined. Setting to 0.0
The original reporter of this bug does not have
   an account here. Reassigning to the person who moved
   it here: chris@bigballofwax.co.nz.
   Previous reporter was Andrew.moore@liblime.com.
The original assignee of this bug does not have
   an account here. Reassigning to the default assignee
   for the component, gmcharlt@gmail.com.
   Previous assignee was Andrew.moore@liblime.com.