Even with bug 21073 pushed, there's no need to fetch the list of plugins implementing the required hooks, on each record in the loop. We should really make the plugins list a parameter to ModBiblio.
Created attachment 91870 [details] [review] Bug 23395: Unit tests
Created attachment 91871 [details] [review] Bug 23395: Add a $plugins parameter to *Biblio and *Item methods This patch adds a $plugin parameter (the way those methods already expect parameters) that is expected to contain an arrayref of plugin object instances. The target scenario are batch operations, in which we really don't want to fetch the available plugins on each iteration. This patch doesn't make batch-related scripts use this new option. It will be done on a follow-up patch. To test: - Apply this patches - Run: $ kshell k$ prove t/db_dependent/Koha/Plugins/Biblio_and_Items_plugin_hooks.t => SUCCESS: All tests pass, new tests as well - Sign off :-D
Created attachment 91872 [details] [review] Bug 23395: Add Test::NoWarrnings dependency
Created attachment 91874 [details] [review] Bug 23395: Fetch the plugins only once in bulkmarcimport.pl
Why did I leave this one ASSIGNED?
Patch no longer applies: Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 23395: Unit tests Using index info to reconstruct a base tree... M t/db_dependent/Koha/Plugins/Biblio_and_Items_plugin_hooks.t Falling back to patching base and 3-way merge... Auto-merging t/db_dependent/Koha/Plugins/Biblio_and_Items_plugin_hooks.t CONFLICT (content): Merge conflict in t/db_dependent/Koha/Plugins/Biblio_and_Items_plugin_hooks.t error: Failed to merge in the changes. Patch failed at 0001 Bug 23395: Unit tests