TO TEST: 1. Add a child patron and link them to either a mother/father guarantor. 2. Go to the parent account and look at the 'relatives checkout' tab 2. Observe the columns are not correct
Created attachment 91903 [details] [review] Bug 23408: Move relatives-issues-table to an include TO test: 1 - Find and adult patron 2 - Add a child account 3 - Check out some things to the child 4 - View the adults account, click 'Relatives checkouts' 5 - Observe table is oddly formatted 6 - View on both the 'Check out' and 'Details' tabs 7 - Apply patch 8 - Tables are displayed correctly
When applying the patch, I get an error on "Check out" and "Details" page : Template process failed: file error - relatives-issues-table.inc: not found at /inlibro/git/koha-master-dev-inlibro/C4/Templates.pm line 122. I think the new file "relatives-issues-table.inc" was not added to the patch.
Created attachment 91944 [details] [review] Bug 23408: Move relatives-issues-table to an include TO test: 1 - Find and adult patron 2 - Add a child account 3 - Check out some things to the child 4 - View the adults account, click 'Relatives checkouts' 5 - Observe table is oddly formatted 6 - View on both the 'Check out' and 'Details' tabs 7 - Apply patch 8 - Tables are displayed correctly
Created attachment 91949 [details] [review] Bug 23408: Move relatives-issues-table to an include TO test: 1 - Find and adult patron 2 - Add a child account 3 - Check out some things to the child 4 - View the adults account, click 'Relatives checkouts' 5 - Observe table is oddly formatted 6 - View on both the 'Check out' and 'Details' tabs 7 - Apply patch 8 - Tables are displayed correctly Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 92127 [details] [review] Bug 23408: Move relatives-issues-table to an include TO test: 1 - Find and adult patron 2 - Add a child account 3 - Check out some things to the child 4 - View the adults account, click 'Relatives checkouts' 5 - Observe table is oddly formatted 6 - View on both the 'Check out' and 'Details' tabs 7 - Apply patch 8 - Tables are displayed correctly Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Nice work! Pushed to master for 19.11.00
Caused by Bug 19719 which added collection column only in circulation.tt
Pushed to 19.05.x for 19.05.04
I cannot properly rebase this for 18.11.x, if we need it please rebase
backported to 18.11.x for 18.11.10