When a patron is registered, via staff or self registration we should fill in the 'lastseen' field
Also on issuing an item?
I'd like to bump this change. We were under reporting our active users because our report was counting when the lastseen date was between two dates, however we had 3000+ active users in the system missed because of the null. If the lastseen date is updated on a SIP connection or CKO, it certainly should be updated when the patron registers. Thanks!
Created attachment 131657 [details] [review] Bug 23486: Set lastseen to default to current timestamp Generally, a patron is not registered without some action from the patron Defaulting the lastseen upon creation seems a reasonable way to set the initial value TO test: Apply patches Update database Create a patron Check their lastseen date
Created attachment 131658 [details] [review] Bug 23486: DO NOT PUSH Schema update
Hi Nick ! I get this error message when I apply the patch in a devbox : Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 23486: Set lastseen to default to current timestamp Applying: Bug 23486: DO NOT PUSH Schema update Using index info to reconstruct a base tree... M Koha/Schema/Result/Borrower.pm Falling back to patching base and 3-way merge... Auto-merging Koha/Schema/Result/Borrower.pm CONFLICT (content): Merge conflict in Koha/Schema/Result/Borrower.pm error: Failed to merge in the changes. Patch failed at 0001 Bug 23486: DO NOT PUSH Schema update hint: Use 'git am --show-current-patch=diff' to see the failed patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-23486-DO-NOT-PUSH-Schema-update-1WltcW.patch I'll be happy to test it when it's fixed, thanks ! Séverine
Created attachment 132222 [details] [review] Bug 23486: DO NOT PUSH Schema update
Sorry Nick, I wasn't quick enough to test the first rebase, I have the same error in my DevBox :/ Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 23486: Set lastseen to default to current timestamp Applying: Bug 23486: DO NOT PUSH Schema update Using index info to reconstruct a base tree... M Koha/Schema/Result/Borrower.pm Falling back to patching base and 3-way merge... Auto-merging Koha/Schema/Result/Borrower.pm CONFLICT (content): Merge conflict in Koha/Schema/Result/Borrower.pm error: Failed to merge in the changes. Patch failed at 0001 Bug 23486: DO NOT PUSH Schema update hint: Use 'git am --show-current-patch=diff' to see the failed patch
Created attachment 134540 [details] [review] Bug 23486: DO NOT PUSH Schema update
Created attachment 134547 [details] [review] Bug 23486: (follow-up) Correct Schema It seems the generated schema handles timestamp incorrectly - this will allow for testing
Created attachment 134549 [details] [review] Bug 23486: Set lastseen to default to current timestamp Generally, a patron is not registered without some action from the patron Defaulting the lastseen upon creation seems a reasonable way to set the initial value TO test: Apply patches Update database Create a patron Check their lastseen date Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr>
Created attachment 134550 [details] [review] Bug 23486: DO NOT PUSH Schema update Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr>
Created attachment 134551 [details] [review] Bug 23486: (follow-up) Correct Schema It seems the generated schema handles timestamp incorrectly - this will allow for testing Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr>
Works nice, well done Nick !!
Please fix the DBIx stuff and submit it in one patch
Created attachment 134963 [details] [review] Bug 23486: Set lastseen to default to current timestamp Generally, a patron is not registered without some action from the patron Defaulting the lastseen upon creation seems a reasonable way to set the initial value TO test: Apply patches Update database Create a patron Check their lastseen date Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr>
Created attachment 134964 [details] [review] Bug 23486: DO NOT PUSH Schema update RM note - manual changes needed to generate
There's something really odd going on here.. I don't understand why current_timestamp is coming out wrong.. though I do have vague recollections of such an issue in the past. However.. I also query.. should the column be updated to 'NOT NULL' too if we're giving it a DEFAULT? Also.. sha1 issues trying to apply the follow-up..
I think if we are going to make it 'NOT NULL' we are going to need to add a DB update, and set any currently null to the dateenrolled. That was we don't 'see' a number of patrons at upgrade