In authorities module, header contains 4 authorities search, from "main heading $a" to "entire record". This is more a search option than really different searches. I propose to merge them into only one with a select for where to search. This allow to always keep current search options.
Created attachment 92648 [details] Screenshot See result
Created attachment 92649 [details] [review] Bug 23562: Only one authorities search in header In authorities module, header contains 4 authorities search, from "main heading $a" to "entire record". This is more a search option than really different searches. I propose to merge them into only one with a select for where to search. This allow to always keep current search options. This patch also adds title arguemnt on comboboxes to say what the represent. Also changes submit button text with "Search" like in many places. Since there is a new combobox, a CSS rule need to be added to have an input text of 20em instead of 30em. Test plan : 1) Go to Authorities module 2) Choose a value different from fist in all comboboxes of header 3) Enter a text in input 4) Click on submit 5) Check that all values and text are kept 6) Perform search with each value of "Where" combobox and check results are OK
Created attachment 92650 [details] [review] Bug 23562: Compiled CSS
I think this patch makes perfectly logical sense but is a step backwards in terms of usability. The tabs allow for a more compact form, whereas with this patch the browser window needs to be fairly wide to accommodate it.
(In reply to Owen Leonard from comment #4) > I think this patch makes perfectly logical sense but is a step backwards in > terms of usability. The tabs allow for a more compact form, whereas with > this patch the browser window needs to be fairly wide to accommodate it. OK. Do you think it will be better if we add the hiding/show of some options, like in patron search (the little [+]) ?
Created attachment 100339 [details] [review] Bug 23562: Only one authorities search in header In authorities module, header contains 4 authorities search, from "main heading $a" to "entire record". This is more a search option than really different searches. I propose to merge them into only one with a select for where to search. This allow to always keep current search options. This patch also adds title arguemnt on comboboxes to say what the represent. Also changes submit button text with "Search" like in many places. Since there is a new combobox, a CSS rule need to be added to have an input text of 20em instead of 30em. Test plan : 1) Go to Authorities module 2) Choose a value different from fist in all comboboxes of header 3) Enter a text in input 4) Click on submit 5) Check that all values and text are kept 6) Perform search with each value of "Where" combobox and check results are OK Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Nice little enhancement, Signing off
(In reply to Fridolin SOMERS from comment #5) > (In reply to Owen Leonard from comment #4) > > I think this patch makes perfectly logical sense but is a step backwards in > > terms of usability. The tabs allow for a more compact form, whereas with > > this patch the browser window needs to be fairly wide to accommodate it. > > OK. > Do you think it will be better if we add the hiding/show of some options, > like in patron search (the little [+]) ? Hmm, I see both sides of this.. I wonder if the 'sort order' could be removed.. it's not so much to do with the search itself but the results and as such feels to me like it doesn't entirely belong here anyway. That would help reduce the width of the field search element somewhat... I sort of like the [+] option as an alternative too, but though I'd throw this idea into the mix.
I also played around with some structural template changes that could be applied more globally. This is one area where we need better responsive layouts. I think this patch can move forward without a "solution," but I did notice one other thing while I was tinkering: Now that we're not using tabs to switch between searches we really should add the other tabs which are generally found there: Check out, Check in, Renew, Search the catalog.
Good call Owen.. I did wonder about the inconsistency in the lack of tabs.