Bug 23578 - Koha ILL backends directory is not included in @INC
Summary: Koha ILL backends directory is not included in @INC
Status: NEW
Alias: None
Product: Koha
Classification: Unclassified
Component: ILL (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal
Assignee: Bugs List
QA Contact:
URL:
Keywords:
Depends on: 19605
Blocks:
  Show dependency treegraph
 
Reported: 2019-09-09 21:06 UTC by Nick Clemens (kidclamp)
Modified: 2024-02-29 12:36 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Nick Clemens (kidclamp) 2019-09-09 21:06:25 UTC
The Koha ILL backends directory can be configured in koha-conf.xml, however, this directory is not included in @INC

To test:
1 - Define backends_directory in koha-conf.xml as /var/lib/koha/instance/Koha/Illbackends
2 - Install a backend there
3 - Restart things, enable ILLModule syspref
4 - Check the about page, it should not have a warning about 'No backends installed'
5 - Try to place a new request - internal server error
6 - Check the plack logs, the module cannot be required
Comment 1 Tomás Cohen Arazi (tcohen) 2019-10-07 15:03:44 UTC
Currently, you need to define in koha-conf.xml the path:

    <backend_directory>__PERL_MODULE_DIR__/Koha/Illbackends</backend_directory>

on this hybrid plugin/ILL backend:

https://gitlab.com/thekesolutions/plugins/koha-plugin-innreach

my approach has been to generate directories for both:


Koha/Illbackends
Koha/Plugin/Com/Theke/INNReach*

they are packaged together. And then on koha-conf.xml I only need to put:

    <backend_directory>/var/lib/koha/plugins/Koha/Illbackends</backend_directory>

We should try it with more than one backend.
Comment 2 Tomás Cohen Arazi (tcohen) 2019-10-07 15:05:34 UTC
(In reply to Tomás Cohen Arazi from comment #1)
>    
> <backend_directory>/var/lib/koha/plugins/Koha/Illbackends</backend_directory>

I meant this:
  
<backend_directory>/var/lib/koha/<instance>/plugins/Koha/Illbackends</backend_directory>
Comment 3 Katrin Fischer 2020-03-29 13:39:49 UTC
Does this still require a fix?
Comment 4 Nick Clemens (kidclamp) 2020-03-30 15:03:45 UTC
We have discussed moving the backends to be traditional Koha plugins, then Tomas' solution works well. We have been using a version of the Koha-2-koha plugin that functions this way and that has been a good workaround.

If we want to support the plugins as-is then this should be addressed
Comment 5 Katrin Fischer 2023-01-13 14:27:51 UTC
I am adding 19605 as a dependency.
Comment 6 Pedro Amorim 2024-02-29 12:36:40 UTC
Adding my suggestion at https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19605#c9 to this discussion.

After 19605 is pushed, we support both ways of loading ILL backends (old backend_dir way and this new plugin way) for a while (1 year? 2 years?) and after that period we deprecate the old backend_dir way of doing things.