As of Bug 14570, Debian jessie no longer works fully as a distribution. That bug uses the DBI method selectall_array() which was added in DBI version 1.635, but Debian jessie only provides 1.631.
The wiki, and possibly other documentation, still states that jessie is a working environment.
The result of this can be seen on about.pl where it will result in an error with an earlier DBI version.
I am not sure if this was intentional - adding Martin as RM.
This certainly wasn't deliberate on my part.
Created attachment 93138 [details] [review]
Bug 23655: Replace selectall_array with selectall_arrayref
The selectall_array method is introduced in DBI version 1.635 which is
not available in Debian Jessie at time of writing.
This patch replaces it with selectall_arrayref which was introduced in
1.631 and is available by default.
Sorry, that's a fail :(
Not an ARRAY reference at /home/vagrant/kohaclone/about.pl line 488
Would it be worth adding a check to the QA script to avoid this happening again?
ooh.. I thought this had been pushed ages ago.. oops.
This is also the cause of our D8 test failures.
The 'Slice' is not required in this case... I've corrected and pushed as I now have the tests passing.
Tip: You can run tests against various versions using koha-testing-docker by prepending ku with a 'KOHA_IMAGE' param.
`KOHA_IMAGE=master-jessie ku` in this case.
Created attachment 94802 [details] [review]
Bug 23655: Restore debian Jessie support
Bug 14570 inadveratntly introduced the use of selectall_array; A feature
that was introduced to DBI version 1.635 which is not available in
debian jessie at the time of writing.
This patch replaces the call with selectall_arrayref which is supported
and works with the rest of the existing code.
Signed-off-by: Martin Renvoize <firstname.lastname@example.org>
Depends on Bug 14570 not in 19.05.x
*** Bug 23850 has been marked as a duplicate of this bug. ***