In the Advanced Cataloging editor, both addbooks.pl and additem.pl have a cataloging search box at the top of the page. It would be great to add one to cataloguing/editor.pl so that users don’t have to click away from the page if they need to perform a new search.
I think this is the case now - when I go to cataloguing we have the normal tabbed search options showing on top. Marking RESOLVED - please reopen if I misunderstood.
Actually, I was mistaken: cataloguing/addbiblio.pl? doesn't always have the searches. Once you actually open a record for editing the searches are gone. I think this was done to save up on space, as the cataloguing form is usually quite long. Do we want to sacrifice the space here for the full search options on top?
Created attachment 121421 [details] [review] Bug 23656: Add hidden search bar to addbiblio and allow toggling This patch adds the search header to the cataloging editor page, defaulted as hidden A new link is added to show the bar, or hide the bar To test: 1 - Apply patch 2 - Load the basic cataloging editor for a book 3 - Note new link near top 'Show search box' 4 - Click it 5 - Search box appears 6 - Click now visible 'Hide search box' 7 - Search box hides 8 - Confirm search box works as expected
Created attachment 122336 [details] [review] Bug 23656: Add hidden search bar to addbiblio and allow toggling This patch adds the search header to the cataloging editor page, defaulted as hidden A new link is added to show the bar, or hide the bar To test: 1 - Apply patch 2 - Load the basic cataloging editor for a book 3 - Note new link near top 'Show search box' 4 - Click it 5 - Search box appears 6 - Click now visible 'Hide search box' 7 - Search box hides 8 - Confirm search box works as expected Signed-off-by: hakam <hakam@inlibro.com>
Created attachment 122337 [details] [review] Bug 23656: Add hidden search bar to addbiblio and allow toggling This patch adds the search header to the cataloging editor page, defaulted as hidden A new link is added to show the bar, or hide the bar To test: 1 - Apply patch 2 - Load the basic cataloging editor for a book 3 - Note new link near top 'Show search box' 4 - Click it 5 - Search box appears 6 - Click now visible 'Hide search box' 7 - Search box hides 8 - Confirm search box works as expected
the button works and everything but when i try to search something or click on anything in the search bar, the search bar disappear even if i press on the options in the search bar like check in and check out
Created attachment 122340 [details] [review] Bug 23656: Add hidden search bar to addbiblio and allow toggling This patch adds the search header to the cataloging editor page, defaulted as hidden A new link is added to show the bar, or hide the bar To test: 1 - Apply patch 2 - Load the basic cataloging editor for a book 3 - Note new link near top 'Show search box' 4 - Click it 5 - Search box appears 6 - Click now visible 'Hide search box' 7 - Search box hides 8 - Confirm search box works as expected
This is fantastic, I love it. But,...it would be nice to see this on the Advanced Editor Cataloging module as well! Thank you for all you do !!!!
Created attachment 123707 [details] [review] Bug 23656: Add hidden search bar to addbiblio and allow toggling This patch adds the search header to the cataloging editor page, defaulted as hidden A new link is added to show the bar, or hide the bar To test: 1 - Apply patch 2 - Load the basic cataloging editor for a book 3 - Note new link near top 'Show search box' 4 - Click it 5 - Search box appears 6 - Click now visible 'Hide search box' 7 - Search box hides 8 - Confirm search box works as expected 9 - Repeat for the advanced cataloging editor
This is fantastic- quick work! I signed off on this: Kelly McElligott kelly@bywatersolutions.com
I can see that this is something that has come up more than once. I am totally ok with us adding this feature, but I feel that it doesn't look quite right yet. 1) Styling If you look at the visible search, it's not "seamless" with the background color. The "Hide/Show" link is stuck to the very left end of the screen without any margin/padding and looks a little out of place. 2) I wonder if it would be more in line with how this page works, to stick the option into the "Settings" section and also make it stick with a cookie as the other options do? At the moment it resets to "hidden" with every page load. Bonus points for thinking about a way to make sure the "Hide/Show" link is translatable :) Could you please have a look and let me know what you think and if we might be able to fix 1) at least?
Yes, the blue gradient on the visible box does not extend across the full screen making it look odd. The position of the link looks like it needs about a 10px top and bottom margin and a 20px left margin to make it look nicer. But the link still looks a little odd and lost on the page to me. I wonder if it should be more of a toggle button? (see attachment) I really like the idea of putting the option into the "Settings" section and making it stick with a cookie. I think this would create a better workflow.
Created attachment 131127 [details] Seachbox toggle example
Created attachment 146743 [details] [review] Bug 23656: Add cataloguing search bar to addbiblio This patch adds the search header to the cataloging editor page. With the staff redesign, this takes up very little space, so I think can be added and visible by default To test: 1 - Apply patch 2 - Load the basic cataloging editor for a bib 3 - Note lack of search bar 4 - Apply patch 5 - Reload the page 6 - You have a search bar
I think the new staff design makes some of the older comments here irrelevant, this works/looks good in the new design.
Created attachment 146850 [details] [review] Bug 23656: Add cataloguing search bar to addbiblio This patch adds the search header to the cataloging editor page. With the staff redesign, this takes up very little space, so I think can be added and visible by default To test: 1 - Apply patch 2 - Load the basic cataloging editor for a bib 3 - Note lack of search bar 4 - Apply patch 5 - Reload the page 6 - You have a search bar Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
(In reply to Lucas Gass from comment #15) > I think the new staff design makes some of the older comments here > irrelevant, this works/looks good in the new design. I agree that the new staff design makes this work well and now the search bar adds some nice consistency.
Created attachment 147356 [details] [review] Bug 23656: Add cataloguing search bar to addbiblio This patch adds the search header to the cataloging editor page. With the staff redesign, this takes up very little space, so I think can be added and visible by default To test: 1 - Apply patch 2 - Load the basic cataloging editor for a bib 3 - Note lack of search bar 4 - Apply patch 5 - Reload the page 6 - You have a search bar Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
Pushed to master for 23.05. Nice work everyone, thanks!