Bug 23656 - Add search box at the top of the cataloging editor page
Summary: Add search box at the top of the cataloging editor page
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Cataloging (show other bugs)
Version: master
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Nick Clemens
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-09-20 14:35 UTC by Barbara Johnson
Modified: 2023-12-28 20:45 UTC (History)
6 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
This adds the search header to the cataloging editor page. With the recent staff interface redesign, this takes up very little space.
Version(s) released in:
23.05.00


Attachments
Bug 23656: Add hidden search bar to addbiblio and allow toggling (1.80 KB, patch)
2021-05-26 10:37 UTC, Nick Clemens
Details | Diff | Splinter Review
Bug 23656: Add hidden search bar to addbiblio and allow toggling (1.84 KB, patch)
2021-06-23 14:09 UTC, Hakam Almotlak
Details | Diff | Splinter Review
Bug 23656: Add hidden search bar to addbiblio and allow toggling (1.80 KB, patch)
2021-06-23 14:12 UTC, Hakam Almotlak
Details | Diff | Splinter Review
Bug 23656: Add hidden search bar to addbiblio and allow toggling (1.85 KB, patch)
2021-06-23 14:28 UTC, Nick Clemens
Details | Diff | Splinter Review
Bug 23656: Add hidden search bar to addbiblio and allow toggling (3.22 KB, patch)
2021-08-10 16:31 UTC, Nick Clemens
Details | Diff | Splinter Review
Seachbox toggle example (140.63 KB, image/png)
2022-02-25 17:30 UTC, Barbara Johnson
Details
Bug 23656: Add cataloguing search bar to addbiblio (1.20 KB, patch)
2023-02-16 16:19 UTC, Nick Clemens
Details | Diff | Splinter Review
Bug 23656: Add cataloguing search bar to addbiblio (1.26 KB, patch)
2023-02-17 15:00 UTC, Lucas Gass
Details | Diff | Splinter Review
Bug 23656: Add cataloguing search bar to addbiblio (1.31 KB, patch)
2023-02-24 16:24 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Barbara Johnson 2019-09-20 14:35:13 UTC
In the Advanced Cataloging editor, both addbooks.pl and additem.pl have a cataloging search box at the top of the page.  It would be great to add one to cataloguing/editor.pl so that users don’t have to click away from the page if they need to perform a new search.
Comment 1 Katrin Fischer 2020-09-20 23:17:03 UTC
I think this is the case now - when I go to cataloguing we have the normal tabbed search options showing on top. Marking RESOLVED - please reopen if I misunderstood.
Comment 2 Katrin Fischer 2020-09-20 23:18:50 UTC
Actually, I was mistaken: cataloguing/addbiblio.pl? doesn't always have the searches. Once you actually open a record for editing the searches are gone.

I think this was done to save up on space, as the cataloguing form is usually quite long. Do we want to sacrifice the space here for the full search options on top?
Comment 3 Nick Clemens 2021-05-26 10:37:53 UTC
Created attachment 121421 [details] [review]
Bug 23656: Add hidden search bar to addbiblio and allow toggling

This patch adds the search header to the cataloging editor page, defaulted as hidden

A new link is added to show the bar, or hide the bar

To test:
1 - Apply patch
2 - Load the basic cataloging editor for a book
3 - Note new link near top 'Show search box'
4 - Click it
5 - Search box appears
6 - Click now visible 'Hide search box'
7 - Search box hides
8 - Confirm search box works as expected
Comment 4 Hakam Almotlak 2021-06-23 14:09:17 UTC Comment hidden (obsolete)
Comment 5 Hakam Almotlak 2021-06-23 14:12:08 UTC Comment hidden (obsolete)
Comment 6 Hakam Almotlak 2021-06-23 14:16:40 UTC
the button works and everything but when i try to search something or click on anything in the search bar, the search bar disappear even if i press on the options in the search bar like check in and check out
Comment 7 Nick Clemens 2021-06-23 14:28:01 UTC
Created attachment 122340 [details] [review]
Bug 23656: Add hidden search bar to addbiblio and allow toggling

This patch adds the search header to the cataloging editor page, defaulted as hidden

A new link is added to show the bar, or hide the bar

To test:
1 - Apply patch
2 - Load the basic cataloging editor for a book
3 - Note new link near top 'Show search box'
4 - Click it
5 - Search box appears
6 - Click now visible 'Hide search box'
7 - Search box hides
8 - Confirm search box works as expected
Comment 8 Kelly McElligott 2021-08-10 16:22:46 UTC
This is fantastic, I love it.  But,...it would be nice to see this on the Advanced Editor Cataloging module as well! Thank you for all you do !!!!
Comment 9 Nick Clemens 2021-08-10 16:31:13 UTC
Created attachment 123707 [details] [review]
Bug 23656: Add hidden search bar to addbiblio and allow toggling

This patch adds the search header to the cataloging editor page, defaulted as hidden

A new link is added to show the bar, or hide the bar

To test:
1 - Apply patch
2 - Load the basic cataloging editor for a book
3 - Note new link near top 'Show search box'
4 - Click it
5 - Search box appears
6 - Click now visible 'Hide search box'
7 - Search box hides
8 - Confirm search box works as expected
9 - Repeat for the advanced cataloging editor
Comment 10 Kelly McElligott 2021-08-10 16:38:32 UTC
This is fantastic- quick work!

I signed off on this: Kelly McElligott
kelly@bywatersolutions.com
Comment 11 Katrin Fischer 2021-10-10 15:44:35 UTC
I can see that this is something that has come up more than once. I am totally ok with us adding this feature, but I feel that it doesn't look quite right yet.

1) Styling
If you look at the visible search, it's not "seamless" with the background color. 

The "Hide/Show" link is stuck to the very left end of the screen without any margin/padding and looks a little out of place.

2) I wonder if it would be more in line with how this page works, to stick the option into the "Settings" section and also make it stick with a cookie as the other options do? At the moment it resets to "hidden" with every page load. 

Bonus points for thinking about a way to make sure the "Hide/Show" link is translatable :) 

Could you please have a look and let me know what you think and if we might be able to fix 1) at least?
Comment 12 Barbara Johnson 2022-02-25 17:29:39 UTC
Yes, the blue gradient on the visible box does not extend across the full screen making it look odd.  The position of the link looks like it needs about a 10px top and bottom margin and a 20px left margin to make it look nicer.  

But the link still looks a little odd and lost on the page to me.  I wonder if it should be more of a toggle button? (see attachment)  

I really like the idea of putting the option into the "Settings" section and  making it stick with a cookie.  I think this would create a better workflow.
Comment 13 Barbara Johnson 2022-02-25 17:30:09 UTC
Created attachment 131127 [details]
Seachbox toggle example
Comment 14 Nick Clemens 2023-02-16 16:19:22 UTC
Created attachment 146743 [details] [review]
Bug 23656: Add cataloguing search bar to addbiblio

This patch adds the search header to the cataloging editor page. With
the staff redesign, this takes up very little space, so I think can be
added and visible by default

To test:
1 - Apply patch
2 - Load the basic cataloging editor for a bib
3 - Note lack of search bar
4 - Apply patch
5 - Reload the page
6 - You have a search bar
Comment 15 Lucas Gass 2023-02-17 15:00:00 UTC
I think the new staff design makes some of the older comments here irrelevant, this works/looks good in the new design.
Comment 16 Lucas Gass 2023-02-17 15:00:42 UTC
Created attachment 146850 [details] [review]
Bug 23656: Add cataloguing search bar to addbiblio

This patch adds the search header to the cataloging editor page. With
the staff redesign, this takes up very little space, so I think can be
added and visible by default

To test:
1 - Apply patch
2 - Load the basic cataloging editor for a bib
3 - Note lack of search bar
4 - Apply patch
5 - Reload the page
6 - You have a search bar

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 17 Katrin Fischer 2023-02-24 16:23:53 UTC
(In reply to Lucas Gass from comment #15)
> I think the new staff design makes some of the older comments here
> irrelevant, this works/looks good in the new design.

I agree that the new staff design makes this work well and now the search bar adds some nice consistency.
Comment 18 Katrin Fischer 2023-02-24 16:24:19 UTC
Created attachment 147356 [details] [review]
Bug 23656: Add cataloguing search bar to addbiblio

This patch adds the search header to the cataloging editor page. With
the staff redesign, this takes up very little space, so I think can be
added and visible by default

To test:
1 - Apply patch
2 - Load the basic cataloging editor for a bib
3 - Note lack of search bar
4 - Apply patch
5 - Reload the page
6 - You have a search bar

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
Comment 19 Tomás Cohen Arazi 2023-02-24 20:38:29 UTC
Pushed to master for 23.05.

Nice work everyone, thanks!