Bug 23742 - Language check on 2 characters only
Summary: Language check on 2 characters only
Status: NEW
Alias: None
Product: Koha
Classification: Unclassified
Component: Mana-kb (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement
Assignee: Bugs List
QA Contact:
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-10-04 12:08 UTC by Paul Poulain
Modified: 2019-10-15 17:11 UTC (History)
0 users

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Paul Poulain 2019-10-04 12:08:52 UTC
Languages checks are made on the full language code (fr_FR). We need only the first 2. Thus, reports with language fr_FR are displayed also for our canadian-Quebec friends (same thing for en_EN, en_US, en_NZ, of course)
Comment 1 Katrin Fischer 2019-10-05 08:02:48 UTC
I am not sure if this will work well for all languages - I seem to remember for some languages the difference is quite big (like different scripts used to write). Also spelling differences between the different en. Fine with the change, but we might want to add to the logic later on when problems appear.
Comment 2 Katrin Fischer 2019-10-05 08:05:16 UTC
(In reply to Katrin Fischer from comment #1)
> I am not sure if this will work well for all languages - I seem to remember
> for some languages the difference is quite big (like different scripts used
> to write). Also spelling differences between the different en. Fine with the
> change, but we might want to add to the logic later on when problems appear.

Thining it over a bit more... I think we would want that for de-DE and de-CH despite differences in spelling. So good idea :)