Bug 23773 - Send MEMBERSHIP_EXPIRY notice by SMS
Summary: Send MEMBERSHIP_EXPIRY notice by SMS
Status: Needs documenting
Alias: None
Product: Koha
Classification: Unclassified
Component: Notices (show other bugs)
Version: master
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Julian Maurice
QA Contact: Kyle M Hall
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-10-08 08:20 UTC by Michal Denar
Modified: 2023-06-08 16:50 UTC (History)
7 users (show)

See Also:
Change sponsored?: Sponsored
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.05.00


Attachments
Bug 23773: Send membership expiry notices by sms too (3.71 KB, patch)
2023-03-13 14:57 UTC, Julian Maurice
Details | Diff | Splinter Review
Bug 23773: Send membership expiry notices by sms too (3.76 KB, patch)
2023-03-15 19:07 UTC, Lucas Gass
Details | Diff | Splinter Review
Bug 23773: Send membership expiry notices by sms too (3.82 KB, patch)
2023-04-28 17:54 UTC, Kyle M Hall
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Michal Denar 2019-10-08 08:20:37 UTC
Hello,
we could make expiry notices more louder. Some libraries've great experience with this kind of messages distributed by SMS. Borrowers react positive, more than by email.
Comment 1 Julian Maurice 2022-07-21 12:51:31 UTC
I'm working on that. Marking as assigned
Comment 2 Julian Maurice 2023-03-13 14:57:18 UTC
Created attachment 148123 [details] [review]
Bug 23773: Send membership expiry notices by sms too

Test plan:
1. Verify in "About" page that SMS::Send is installed.
   If not, install it.
2. Set system preferences:
   - SMSSendDriver = 'Test'
   - MembershipExpiryDaysNotice = 30
3. In "Notices and Slips" tool, edit the 'MEMBERSHIP_EXPIRY' letter and
   verify that both email and sms parts are filled. Use a different
   title and body for the sms part
4. Create a new borrower with an email address and an SMS number. Set
   their expiry date to a date next week
5. Run misc/cronjobs/membership_expiry.pl --confirm
6. Verify in the patron "Notices" tab that two notices are pending, one
   for email, one for sms

Sponsored-by: Médiathèque de Montauban
Comment 3 Lucas Gass 2023-03-15 19:07:31 UTC
Created attachment 148244 [details] [review]
Bug 23773: Send membership expiry notices by sms too

Test plan:
1. Verify in "About" page that SMS::Send is installed.
   If not, install it.
2. Set system preferences:
   - SMSSendDriver = 'Test'
   - MembershipExpiryDaysNotice = 30
3. In "Notices and Slips" tool, edit the 'MEMBERSHIP_EXPIRY' letter and
   verify that both email and sms parts are filled. Use a different
   title and body for the sms part
4. Create a new borrower with an email address and an SMS number. Set
   their expiry date to a date next week
5. Run misc/cronjobs/membership_expiry.pl --confirm
6. Verify in the patron "Notices" tab that two notices are pending, one
   for email, one for sms

Sponsored-by: Médiathèque de Montauban

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 4 David Cook 2023-04-11 06:15:08 UTC
I've had a library ask for this and I thought it sounded familiar...

I'll make a note to come back to this when I have more time.
Comment 5 Kyle M Hall 2023-04-28 17:54:01 UTC
Created attachment 150406 [details] [review]
Bug 23773: Send membership expiry notices by sms too

Test plan:
1. Verify in "About" page that SMS::Send is installed.
   If not, install it.
2. Set system preferences:
   - SMSSendDriver = 'Test'
   - MembershipExpiryDaysNotice = 30
3. In "Notices and Slips" tool, edit the 'MEMBERSHIP_EXPIRY' letter and
   verify that both email and sms parts are filled. Use a different
   title and body for the sms part
4. Create a new borrower with an email address and an SMS number. Set
   their expiry date to a date next week
5. Run misc/cronjobs/membership_expiry.pl --confirm
6. Verify in the patron "Notices" tab that two notices are pending, one
   for email, one for sms

Sponsored-by: Médiathèque de Montauban
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 6 Kyle M Hall 2023-04-28 17:55:05 UTC
QA note: My initial reaction was to require a cli switch, but simply not having that notice will disable the feature from the UI, which is preferable.
Comment 7 David Cook 2023-05-18 06:24:56 UTC
Curious if this one will make it into 23.05
Comment 8 Tomás Cohen Arazi 2023-05-18 14:35:44 UTC
Pushed to master for 23.05.

Nice work everyone, thanks!
Comment 9 Matt Blenkinsop 2023-06-08 16:50:07 UTC
Enhancement - not backporting to 22.11.x