Bug 23948 - Move mandatory .sql files to the mandatory/ directory
Summary: Move mandatory .sql files to the mandatory/ directory
Status: RESOLVED DUPLICATE of bug 23895
Alias: None
Product: Koha
Classification: Unclassified
Component: Installation and upgrade (command-line installer) (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement
Assignee: Bugs List
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-11-01 18:13 UTC by Tomás Cohen Arazi (tcohen)
Modified: 2019-11-04 10:31 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tomás Cohen Arazi (tcohen) 2019-11-01 18:13:54 UTC 
Some files exist in the root directory (installer/data/mysql) and some other in the mandatory/ one. All should be put in the mandatory one. The current 'layout' becomes particularly troublesome on this commit:

https://gitlab.com/koha-community/koha-misc4dev/commit/7ecb9de5b6c7ef660ff63254e802a8ec42199a13

After that commit, the tools won't work for earlier versions that don't have that .sql files. If they were put in the mandatory directory there would be no need to explicitly list them or branching in the code depending on the version (possible workaround in koha-misc4dev).
Comment 1 Martin Renvoize (ashimema) 2019-11-01 20:28:26 UTC 
See bug 23895 which I think it's a duplicate of this.

Actually, just moving them doesn't mean they don't have to be explicitly listed, right now the code in C4/Installer lists all mandatory files to nature correct load order.. silly huh.

What 'tools' are you talking about?  I've already updated misc4dev.
Comment 2 Jonathan Druart 2019-11-04 10:31:13 UTC 

*** This bug has been marked as a duplicate of bug 23895 ***