Bug 23953 - Cancelling hold does not work if checkout not completed
Summary: Cancelling hold does not work if checkout not completed
Status: NEW
Alias: None
Product: Koha
Classification: Unclassified
Component: Circulation (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal (vote)
Assignee: Bugs List
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-11-03 21:13 UTC by Aleisha Amohia
Modified: 2019-12-12 13:13 UTC (History)
5 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Aleisha Amohia 2019-11-03 21:13:01 UTC
To reproduce:

1. Place a hold on item A for patron A
2. Check out item A to patron B
3. See the prompt to confirm the checkout because the hold for patron A exists. Check the 'cancel hold' checkbox and click the 'No, don't check out' button
4. Notice the hold for patron A is NOT cancelled <-- bug
5. Attempt to check out item to patron B again
6. This time, check the 'cancel hold' checkbox but click the 'Yes, check out' button
7. Notice that item A is successfully checked out to patron B and the hold for patron A has been cancelled.

Therefore, the 'cancel hold' checkbox does not work if the checkout is not completed.
Comment 1 Jonathan Druart 2019-11-11 16:07:05 UTC
Looks like a long standing issue and I did not find a duplicated bug report, that's weird.

At first glance I would say the checkbox is only taken into consideration for "Yes, check out"

https://snipboard.io/jEXNBP.jpg

Not sure how we could make it clear on the interface.
Comment 2 Aleisha Amohia 2019-11-11 20:28:37 UTC
Yes it is a weird one. I think given that the option is a checkbox, it does imply that it's a separate action to the button, and you should be able to cancel a hold while clicking any button.
In this case I think we just need to ensure that the cancel hold checkbox is considered if any of the buttons is clicked.

Otherwise, the checkbox should be removed and the cancel hold action should be a second screen confirmation, after choosing "Yes, check out".
Comment 3 Jonathan Druart 2019-11-12 08:51:09 UTC
Something like that? https://snipboard.io/UXsqMB.jpg
Comment 4 Jonathan Druart 2019-11-12 08:52:17 UTC
(In reply to Jonathan Druart from comment #3)
> Something like that? https://snipboard.io/UXsqMB.jpg

Actually it's more than 2 options as there is also another checkbox for "Revert waiting status", if the hold is waiting.
Comment 5 Aleisha Amohia 2019-11-12 20:03:37 UTC
(In reply to Jonathan Druart from comment #4)
> (In reply to Jonathan Druart from comment #3)
> > Something like that? https://snipboard.io/UXsqMB.jpg
> 
> Actually it's more than 2 options as there is also another checkbox for
> "Revert waiting status", if the hold is waiting.

That could work! Would just also need the "Yes, check out and revert waiting status" option too. And to standardise the style of the other buttons.