When hold policy override is enabled and the librarian tries to place a hold on an title which would otherwise not be available to be placed on hold, the input button is shown with a "warning" icon. Elsewhere in this template this image icon was replaced with a Font Awesome icon (in Bug 14695). This should be done for the inputs as well.
Created attachment 94989 [details] [review] Bug 23957: Remove button style with famfamfam icon background and replace with Font Awesome The patch modifies the markup and CSS related to the holds template in the staff client when holds policy override is necessary. The CSS background image is replaced with a Font Awesome icon. <input>s are replaced with <button>s to allow for the icon markup. To test, apply the patch and regenerate the staff client CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). - Enable the AllowHoldPolicyOverride system preference. - Start the process of placing a hold for a patron on a title which would not normally be available for hold. For instance: The patron already has too many holds. - On the hold confirmation screen the "Place hold" buttons should appear with a little yellow "warning" icon. - Clicking either of the two "Place hold" buttons should trigger a confirmation dialog. Test both the "Confirm" and "Cancel" options.
(In reply to Owen Leonard from comment #0) > This should be done for the inputs as well. Why not on the same patch? $ yarn build Message: koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss Error: Invalid CSS after "...hadow: 0 -1px 0": expected expression (e.g. 1px, bold), was "#00000059;" on line 1794 of koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss >> text-shadow: 0 -1px 0 #00000059; ----------------------------------^ The hex code color is not valid.
Created attachment 95027 [details] [review] Bug 23957: Remove button style with famfamfam icon background and replace with Font Awesome The patch modifies the markup and CSS related to the holds template in the staff client when holds policy override is necessary. The CSS background image is replaced with a Font Awesome icon. <input>s are replaced with <button>s to allow for the icon markup. To test, apply the patch and regenerate the staff client CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). - Enable the AllowHoldPolicyOverride system preference. - Start the process of placing a hold for a patron on a title which would not normally be available for hold. For instance: The patron already has too many holds. - On the hold confirmation screen the "Place hold" buttons should appear with a little yellow "warning" icon. - Clicking either of the two "Place hold" buttons should trigger a confirmation dialog. Test both the "Confirm" and "Cancel" options.
(In reply to Jonathan Druart from comment #2) > (In reply to Owen Leonard from comment #0) > > This should be done for the inputs as well. > > Why not on the same patch? My comment refers to the changes made in the patch.
Created attachment 95244 [details] [review] Bug 23957: Remove button style with famfamfam icon background and replace with Font Awesome The patch modifies the markup and CSS related to the holds template in the staff client when holds policy override is necessary. The CSS background image is replaced with a Font Awesome icon. <input>s are replaced with <button>s to allow for the icon markup. To test, apply the patch and regenerate the staff client CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). - Enable the AllowHoldPolicyOverride system preference. - Start the process of placing a hold for a patron on a title which would not normally be available for hold. For instance: The patron already has too many holds. - On the hold confirmation screen the "Place hold" buttons should appear with a little yellow "warning" icon. - Clicking either of the two "Place hold" buttons should trigger a confirmation dialog. Test both the "Confirm" and "Cancel" options. Signed-off-by: Maryse Simard <maryse.simard@inlibro.com>
Hi Owen, I have some difficulties with this bug. The second "Place hold" button on the end of the page does no longer 'lock' when it should. Example: - override is not active - try to place a hold on a record with only 'not for loan' itemtypes - the first 'place hold' button is locked, but the second after the item table is not.
Created attachment 96156 [details] [review] Bug 23957: (follow-up) Disable both place hold buttons This follow-up adds the correct markup to the second of two "Place hold" buttons so that it is disabled when the first is disabled.
Created attachment 96578 [details] [review] Bug 23957: Remove button style with famfamfam icon background and replace with Font Awesome The patch modifies the markup and CSS related to the holds template in the staff client when holds policy override is necessary. The CSS background image is replaced with a Font Awesome icon. <input>s are replaced with <button>s to allow for the icon markup. To test, apply the patch and regenerate the staff client CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). - Enable the AllowHoldPolicyOverride system preference. - Start the process of placing a hold for a patron on a title which would not normally be available for hold. For instance: The patron already has too many holds. - On the hold confirmation screen the "Place hold" buttons should appear with a little yellow "warning" icon. - Clicking either of the two "Place hold" buttons should trigger a confirmation dialog. Test both the "Confirm" and "Cancel" options. Signed-off-by: Maryse Simard <maryse.simard@inlibro.com>
Created attachment 96579 [details] [review] Bug 23957: (follow-up) Disable both place hold buttons This follow-up adds the correct markup to the second of two "Place hold" buttons so that it is disabled when the first is disabled.
Nice work everyone! Pushed to master for 20.05
Pushed to 19.11.x branch for 19.11.02
there is many merge conflicts when applying this to 19.05.x, I am going to skip backporting it.