t/db_dependent/Koha/Objects/Mixin/AdditionalFields.t .. 1/12 # Failed test '->additional_field_values should return the correct values' # at t/db_dependent/Koha/Objects/Mixin/AdditionalFields.t line 82. # Structures begin differing at: # $got->[0]{value} = 'bar value for basket2' # $expected->[0]{value} = 'foo value for basket2' # Looks like you failed 1 test of 12. We do not really know why, but the values are not returned in the order they are stored in DB. Fixing this random failure for now at test level.
Created attachment 95187 [details] [review] Bug 23994: Fix random failure from AdditionalFields.t (U18) t/db_dependent/Koha/Objects/Mixin/AdditionalFields.t .. 1/12 # Failed test '->additional_field_values should return the correct values' # at t/db_dependent/Koha/Objects/Mixin/AdditionalFields.t line 82. # Structures begin differing at: # $got->[0]{value} = 'bar value for basket2' # $expected->[0]{value} = 'foo value for basket2' # Looks like you failed 1 test of 12. We do not really know why, but the values are not returned in the order they are stored in DB. Fixing this random failure for now at test level.
As discussed on IRC, this works and gets the tests passing again... no idea why it returns differently on U18 but the order is unimportant in the context anyway. Passing QA and Pushing.
I cannot make this fail in 19.05.x, do we need it in that version?
(In reply to Lucas Gass from comment #3) > I cannot make this fail in 19.05.x, do we need it in that version? Yes, it should fail on U18 as well.
(In reply to Lucas Gass from comment #3) > I cannot make this fail in 19.05.x, do we need it in that version? I have this failing locally often (whereas it seems ok in the CI), it must depend a lot of the machine. So need in 19.05.x is confirmed.
Wait it's already in 19.11 since a long time. Great I can backport it :)
Backported to 19.05.x branch for 19.05.12