Bug 23994 - AdditionalFields.t is failing randomly (U18)
Summary: AdditionalFields.t is failing randomly (U18)
Status: Pushed to master
Alias: None
Product: Koha
Classification: Unclassified
Component: Test Suite (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Chris Cormack
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-11-08 09:27 UTC by Jonathan Druart
Modified: 2019-11-08 09:35 UTC (History)
1 user (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Who signed the patch off:
Text to go in the release notes:
Version(s) released in:
19.11.00


Attachments
Bug 23994: Fix random failure from AdditionalFields.t (U18) (1.44 KB, patch)
2019-11-08 09:29 UTC, Jonathan Druart
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Druart 2019-11-08 09:27:41 UTC
t/db_dependent/Koha/Objects/Mixin/AdditionalFields.t .. 1/12 
#   Failed test '->additional_field_values should return the correct values'
#   at t/db_dependent/Koha/Objects/Mixin/AdditionalFields.t line 82.
#     Structures begin differing at:
#          $got->[0]{value} = 'bar value for basket2'
#     $expected->[0]{value} = 'foo value for basket2'
# Looks like you failed 1 test of 12.

We do not really know why, but the values are not returned in the order they are stored in DB. Fixing this random failure for now at test level.
Comment 1 Jonathan Druart 2019-11-08 09:29:00 UTC
Created attachment 95187 [details] [review]
Bug 23994: Fix random failure from AdditionalFields.t (U18)

t/db_dependent/Koha/Objects/Mixin/AdditionalFields.t .. 1/12
 #   Failed test '->additional_field_values should return the correct values'
 #   at t/db_dependent/Koha/Objects/Mixin/AdditionalFields.t line 82.
 #     Structures begin differing at:
 #          $got->[0]{value} = 'bar value for basket2'
 #     $expected->[0]{value} = 'foo value for basket2'
 # Looks like you failed 1 test of 12.

We do not really know why, but the values are not returned in the order they are stored in DB. Fixing this random failure for now at test level.
Comment 2 Martin Renvoize 2019-11-08 09:34:32 UTC
As discussed on IRC, this works and gets the tests passing again... no idea why it returns differently on U18 but the order is unimportant in the context anyway.  Passing QA and Pushing.