Bug 24011 - Browser tabs auto close when editing items from report with biblio links
Summary: Browser tabs auto close when editing items from report with biblio links
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Reports (show other bugs)
Version: 19.05
Hardware: All All
: P5 - low normal
Assignee: Bugs List
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-11-11 16:51 UTC by Myka Kennedy Stephens
Modified: 2020-11-30 21:45 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Myka Kennedy Stephens 2019-11-11 16:51:10 UTC
Since upgrading to 19.05, following a linked biblionumber from a report and making an edit to an item will close the new browser tab after the edit is complete. This is not desired behavior (at least for my library) because it doesn't allow us to check for accuracy after saving changes and it does not allow the opportunity to make edits to additional items attached to the record. The link has to be clicked again from the report to be able to see the record view.

To test:
1. Create a report with linked biblios that includes this snippet of SQL code:
CONCAT('<a target="_blank" href=\"/cgi-bin/koha/catalogue/detail.pl?biblionumber=',b.biblionumber,'\">',b.biblionumber,'</a>') as biblionumber
2. Run the report
3. Click on a biblio link; the record view opens in a new browser tab
4. Click on the edit item button; the edit item screen loads
5. Make a change to the item; click save changes
6. The browser tab closes, leaving only the report tab open.

Note, the changes do appear to save before the tab closes. I suspect that a well-meaning developer intended for this to be a shortcut or time saver, but it is a major annoyance when attempting to make edits from a report and the record has multiple items attached. It would also be nice to have visual confirmation that the changes were indeed saved and they are accurate. The tab auto-closes before the user gets that visual confirmation.
Comment 1 Myka Kennedy Stephens 2019-11-12 14:52:28 UTC
I would also like to add that selecting "edit items" from the edit menu will force the tab to close. I.e., Follow steps 1-3, then instead of clicking the edit item button, select "edit items" from the edit menu button. The tab closes without loading the additem.pl page
Comment 2 Jonathan Druart 2019-11-20 11:06:28 UTC
Works ok for me on master and 19.05.x

Which exact version of Koha are you using?
Which browser (and version)?
Comment 3 Katrin Fischer 2019-11-20 11:46:32 UTC
(In reply to Myka Kennedy Stephens from comment #1)
> I would also like to add that selecting "edit items" from the edit menu will
> force the tab to close. I.e., Follow steps 1-3, then instead of clicking the
> edit item button, select "edit items" from the edit menu button. The tab
> closes without loading the additem.pl page

This has been fixed with bug 23680 - are you on the most recent 19.05 version?
Comment 4 Myka Kennedy Stephens 2019-11-20 14:33:05 UTC
We are on 19.05.04.000.

I just tested this on 19.05.04.001, and you are correct that it has been fixed. I will advise our support company that we need a minor point upgrade.

Thank you!