When loading returns.pl, code to check rotating collections fires off an search for items by barcode, but doesn't check for a barcode first. This means the code will search for items where barcode is NULL, which is definitely not the intended function.
Created attachment 95805 [details] [review] Bug 24106: In returns.pl, don't search for item if no barcode is provided When loading returns.pl, code to check rotating collections fires off an search for items by barcode, but doesn't check for a barcode first. This means the code will search for items where barcode is NULL, which is definitely not the intended function. Test Plan: 1) Apply this patch 2) Set up a rotating collection with items 3) Transfer the collection 4) Check in a rotating collection item 5) Note no change in functionality
Created attachment 95806 [details] [review] Bug 24106: In returns.pl, don't search for item if no barcode is provided When loading returns.pl, code to check rotating collections fires off an search for items by barcode, but doesn't check for a barcode first. This means the code will search for items where barcode is NULL, which is definitely not the intended function. Test Plan: 1) Apply this patch 2) Set up a rotating collection with items 3) Transfer the collection 4) Check in a rotating collection item 5) Note no change in functionality Signed-off-by: Liz Rea <wizzyrea@gmail.com>
Created attachment 95883 [details] [review] Bug 24106: In returns.pl, don't search for item if no barcode is provided When loading returns.pl, code to check rotating collections fires off an search for items by barcode, but doesn't check for a barcode first. This means the code will search for items where barcode is NULL, which is definitely not the intended function. Test Plan: 1) Apply this patch 2) Set up a rotating collection with items 3) Transfer the collection 4) Check in a rotating collection item 5) Note no change in functionality Signed-off-by: Liz Rea <wizzyrea@gmail.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
It appears that this can cause Koha to hang looking for all the null barcode items when processing holds, enough retries and all of the plack processes get eaten up. It doesn't happen for every library, however, so it must be related to a system preference, which I have not tracked down (yet).
Nice work everyone! Pushed to master for 20.05
Pushed to 19.11.01
backported to 19.05.x for 19.05.06