Bug 24157 - Additional acquisitions permissions
Summary: Additional acquisitions permissions
Status: Signed Off
Alias: None
Product: Koha
Classification: Unclassified
Component: Architecture, internals, and plumbing (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Jonathan Druart
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-12-03 19:34 UTC by Jonathan Druart
Modified: 2020-03-25 11:29 UTC (History)
3 users (show)

See Also:
Change sponsored?: Sponsored
Patch complexity: ---
Who signed the patch off:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 24157: New permission - reopen_closed_invoices (11.38 KB, patch)
2019-12-13 17:10 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 24157: New permission - edit_invoices (32.70 KB, patch)
2019-12-13 17:10 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 24157: Add new method Acq::Invoice::Adjustement->fund (2.37 KB, patch)
2019-12-13 17:10 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 24157: New permission - delete_invoices (5.17 KB, patch)
2019-12-13 17:10 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 24157: New permission - delete_baskets (5.97 KB, patch)
2019-12-13 17:10 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 24157: New permission - reopen_closed_invoices (11.31 KB, patch)
2020-02-10 13:53 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 24157: New permission - edit_invoices (32.40 KB, patch)
2020-02-10 13:53 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 24157: Add new method Acq::Invoice::Adjustement->fund (2.36 KB, patch)
2020-02-10 13:53 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 24157: New permission - delete_invoices (5.16 KB, patch)
2020-02-10 13:53 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 24157: New permission - delete_baskets (5.97 KB, patch)
2020-02-10 13:53 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 24157: New permission - reopen_closed_invoices (11.44 KB, patch)
2020-03-06 19:19 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 24157: New permission - edit_invoices (32.49 KB, patch)
2020-03-06 19:19 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 24157: Add new method Acq::Invoice::Adjustement->fund (2.42 KB, patch)
2020-03-06 19:19 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 24157: New permission - delete_invoices (5.22 KB, patch)
2020-03-06 19:19 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 24157: New permission - delete_baskets (6.03 KB, patch)
2020-03-06 19:19 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 24157: (follow-up) Conditionally show controls to reopen and close invoice (2.43 KB, patch)
2020-03-06 19:19 UTC, Owen Leonard
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Druart 2019-12-03 19:34:23 UTC
Add separate permissions allowing selected users to:
 * Reopen a closed invoice
 * Edit an invoice
 * Delete a basket
 * Delete an invoice
Comment 1 Jonathan Druart 2019-12-13 17:10:12 UTC Comment hidden (obsolete)
Comment 2 Jonathan Druart 2019-12-13 17:10:15 UTC Comment hidden (obsolete)
Comment 3 Jonathan Druart 2019-12-13 17:10:18 UTC Comment hidden (obsolete)
Comment 4 Jonathan Druart 2019-12-13 17:10:22 UTC Comment hidden (obsolete)
Comment 5 Jonathan Druart 2019-12-13 17:10:25 UTC Comment hidden (obsolete)
Comment 6 Martin Renvoize 2020-02-10 13:53:42 UTC
Created attachment 98651 [details] [review]
Bug 24157: New permission - reopen_closed_invoices

New permission to reopen a closed invoice.

Test plan:
- Remove the new permission "reopen_closed_invoices" for a given patron,
use it to log in into Koha
- Create an invoice, close it
=> You are not able to reopen the invoice
- Add the permission
=> You are able to reopen the invoice

Sponsored-by: Galway-Mayo Institute of Technology
Comment 7 Martin Renvoize 2020-02-10 13:53:45 UTC
Created attachment 98652 [details] [review]
Bug 24157: New permission - edit_invoices

Add a new permission to edit invoices

Test plan:
- Remove the new permission "edit_invoices" for a given patron,
use it to log in into Koha
- Create an invoice, edit it (click "detail")
=> You can see the detail of the invoice, but cannot edit it. It's a read-only view.
- Add the permission
=> The form is back and you can modify the invoices and save the changes.
Also, you are able to create adjustments.

Sponsored-by: Galway-Mayo Institute of Technology
Comment 8 Martin Renvoize 2020-02-10 13:53:49 UTC
Created attachment 98653 [details] [review]
Bug 24157: Add new method Acq::Invoice::Adjustement->fund

Moving to its own commit in case we want to cherry-pick or move it to
its own bug report.

Sponsored-by: Galway-Mayo Institute of Technology
Comment 9 Martin Renvoize 2020-02-10 13:53:52 UTC
Created attachment 98654 [details] [review]
Bug 24157: New permission - delete_invoices

Add a new permission to delete invoices

Test plan:
- Remove the new permission "delete_invoices" for a given patron,
use it to log in into Koha
- Create an invoice, try to delete it
=> There is no way to delete it
- Add the permission
=> Now you can delete the invoice

Sponsored-by: Galway-Mayo Institute of Technology
Comment 10 Martin Renvoize 2020-02-10 13:53:55 UTC
Created attachment 98655 [details] [review]
Bug 24157: New permission - delete_baskets

Add a new permission to delete acquisition baskets

Test plan:
- Remove the new permission "delete_basket" for a given patron,
use it to log in into Koha
- Create basket, try to delete it
=> There is no way to delete it
- Add the permission
=> Now you can delete the basket

Sponsored-by: Galway-Mayo Institute of Technology
Comment 11 Martin Renvoize 2020-02-10 13:54:16 UTC
Rebased to allow the application to sandboxes for testing.
Comment 12 Owen Leonard 2020-03-06 19:19:24 UTC
Created attachment 100283 [details] [review]
Bug 24157: New permission - reopen_closed_invoices

New permission to reopen a closed invoice.

Test plan:
- Remove the new permission "reopen_closed_invoices" for a given patron,
use it to log in into Koha
- Create an invoice, close it
=> You are not able to reopen the invoice
- Add the permission
=> You are able to reopen the invoice

Sponsored-by: Galway-Mayo Institute of Technology

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 13 Owen Leonard 2020-03-06 19:19:27 UTC
Created attachment 100284 [details] [review]
Bug 24157: New permission - edit_invoices

Add a new permission to edit invoices

Test plan:
- Remove the new permission "edit_invoices" for a given patron,
use it to log in into Koha
- Create an invoice, edit it (click "detail")
=> You can see the detail of the invoice, but cannot edit it. It's a read-only view.
- Add the permission
=> The form is back and you can modify the invoices and save the changes.
Also, you are able to create adjustments.

Sponsored-by: Galway-Mayo Institute of Technology

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 14 Owen Leonard 2020-03-06 19:19:30 UTC
Created attachment 100285 [details] [review]
Bug 24157: Add new method Acq::Invoice::Adjustement->fund

Moving to its own commit in case we want to cherry-pick or move it to
its own bug report.

Sponsored-by: Galway-Mayo Institute of Technology

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 15 Owen Leonard 2020-03-06 19:19:33 UTC
Created attachment 100286 [details] [review]
Bug 24157: New permission - delete_invoices

Add a new permission to delete invoices

Test plan:
- Remove the new permission "delete_invoices" for a given patron,
use it to log in into Koha
- Create an invoice, try to delete it
=> There is no way to delete it
- Add the permission
=> Now you can delete the invoice

Sponsored-by: Galway-Mayo Institute of Technology

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 16 Owen Leonard 2020-03-06 19:19:36 UTC
Created attachment 100287 [details] [review]
Bug 24157: New permission - delete_baskets

Add a new permission to delete acquisition baskets

Test plan:
- Remove the new permission "delete_basket" for a given patron,
use it to log in into Koha
- Create basket, try to delete it
=> There is no way to delete it
- Add the permission
=> Now you can delete the basket

Sponsored-by: Galway-Mayo Institute of Technology

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 17 Owen Leonard 2020-03-06 19:19:38 UTC
Created attachment 100288 [details] [review]
Bug 24157: (follow-up) Conditionally show controls to reopen and close invoice

This follow-up makes minor changes to the template so that the checkbox
for reopening or closing an invoice are not displayed when the user
doens't have the correct permissions.

To test, apply the patch and try the process of viewing or editing an
invoice as a user with these various permissions:

 - edit_invoices ON
 - edit_invoices OFF
 - reopen_closed_invoices ON
 - reopen_closed_invoices OFF
Comment 18 Martin Renvoize 2020-03-25 11:29:28 UTC
Followup looks good to me.. Setting to signedoff :)