* Add note column to late orders table * Add ISBN column to late orders table * Add quantity column to late orders table * Add order number column to late orders table (with link to basket)
Hi Jonathan, there is a slight overlap with the SO patch for bug 12502 (ISBN, order number)
Created attachment 97124 [details] [review] Bug 24162: Add quantity column to the late orders page This patch add a new column "quantity" to the late orders page Test plan: 1. Create some orders, close the basket 2. Go to the "Late orders" page => You should see a new column "quantity" that contains the number of items of the order Sponsored-by: Cork Institute of Technology
Created attachment 98693 [details] [review] Bug 24162: Add quantity column to the late orders page This patch add a new column "quantity" to the late orders page Test plan: 1. Create some orders, close the basket 2. Go to the "Late orders" page => You should see a new column "quantity" that contains the number of items of the order Sponsored-by: Cork Institute of Technology
Created attachment 99779 [details] [review] Bug 24162: Add quantity column to the late orders page This patch add a new column "quantity" to the late orders page Test plan: 1. Create some orders, close the basket 2. Go to the "Late orders" page => You should see a new column "quantity" that contains the number of items of the order Sponsored-by: Cork Institute of Technology Signed-off-by: Devinim <kohadevinim@devinim.com.tr>
This is signed off - but its dependency is not? Moving to BLOCKED until resolved.
1) QA tools FAIL koha-tmpl/intranet-tmpl/prog/en/modules/acqui/lateorders.tt FAIL filters missing_filter at line 111 ( <td>[% lateorder.quantity %]</td>) 2) Column configuration Quantity also needs to be added to the column configuration files. I'd usually just fix this, but because of the dependencies I'll leave it be for now.
Created attachment 104195 [details] [review] Bug 24162: Add missing filter
Created attachment 104196 [details] [review] Bug 24162: Add quantity column to the columns settings config
(In reply to Katrin Fischer from comment #6) > 1) QA tools > > FAIL koha-tmpl/intranet-tmpl/prog/en/modules/acqui/lateorders.tt > FAIL filters > missing_filter at line 111 ( <td>[% lateorder.quantity %]</td>) > > 2) Column configuration > > Quantity also needs to be added to the column configuration files. > > I'd usually just fix this, but because of the dependencies I'll leave it be > for now. Oops, fixed!
Created attachment 104342 [details] [review] Bug 24162: Add quantity column to the late orders page This patch add a new column "quantity" to the late orders page Test plan: 1. Create some orders, close the basket 2. Go to the "Late orders" page => You should see a new column "quantity" that contains the number of items of the order Sponsored-by: Cork Institute of Technology Signed-off-by: Devinim <kohadevinim@devinim.com.tr> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 104343 [details] [review] Bug 24162: Add missing filter Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 104344 [details] [review] Bug 24162: Add quantity column to the columns settings config Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Nice work everyone! Pushed to master for 20.05
enhancement not backported to 19.11.x