Bug 24182 - Cancelling a hold floods the logs
Summary: Cancelling a hold floods the logs
Status: RESOLVED DUPLICATE of bug 28700
Alias: None
Product: Koha
Classification: Unclassified
Component: Hold requests (show other bugs)
Version: 19.05
Hardware: All All
: P5 - low normal (vote)
Assignee: Bugs List
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-12-05 16:12 UTC by Nick Clemens
Modified: 2021-08-19 09:00 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Nick Clemens 2019-12-05 16:12:07 UTC
382             C4::Log::logaction( 'HOLDS', 'CANCEL', $self->reserve_id, Dumper($self->unblessed) )
383                 if C4::Context->preference('HoldsLog');


This ends up loggining a date time object for the cancellation date:

357             $self->cancellationdate( dt_from_string->strftime( '%Y-%m-%d %H:%M:%S' ) );
Comment 1 Nick Clemens 2019-12-05 16:15:37 UTC

*** This bug has been marked as a duplicate of bug 23219 ***
Comment 2 Nick Clemens 2019-12-05 16:18:43 UTC
Actually, we may want to cherry-pick the fix for this for stable versions:

$self->cancellationdate(dt_from_string);

to 

$self->cancellationdate( dt_from_string->strftime( '%Y-%m-%d %H:%M:%S' ) );
Comment 3 Jonathan Druart 2021-08-19 09:00:35 UTC

*** This bug has been marked as a duplicate of bug 28700 ***