Bug 24187 - Vertically centre the holding details in each table rows in Cataloguing (staff client) and OPAC
Summary: Vertically centre the holding details in each table rows in Cataloguing (staf...
Status: RESOLVED WONTFIX
Alias: None
Product: Koha
Classification: Unclassified
Component: Architecture, internals, and plumbing (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low minor (vote)
Assignee: Bugs List
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-12-08 11:31 UTC by Iming Chan
Modified: 2023-12-31 10:58 UTC (History)
1 user (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Search results with vertical centering (155.23 KB, image/png)
2019-12-10 14:25 UTC, Owen Leonard
Details
OPAC Holdings (328.41 KB, image/jpeg)
2019-12-11 08:16 UTC, Iming Chan
Details
Staff client catalogue record normal view (312.77 KB, image/jpeg)
2019-12-11 08:18 UTC, Iming Chan
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Iming Chan 2019-12-08 11:31:10 UTC
Vertically centre the holding details in a row to match checkbox and "Edit" button (staff client).  Similar issue found in OPAC Holdings as well.

Also noticed that catalogue details are not algined with field labels in "Normal" view (staff client).
Comment 1 Owen Leonard 2019-12-10 14:25:01 UTC
Created attachment 96159 [details]
Search results with vertical centering

I may be misunderstanding this request but if you're talking about the staff client search results, the reason for not vertically centering the title information is that when you have a lot of items it causes the title information to be strangely distant from the previous row in the table.
Comment 2 Katrin Fischer 2019-12-11 07:03:27 UTC
I agree with Owen that the current behaviour is better. Can you post screenshots for the other points?
Comment 3 Iming Chan 2019-12-11 08:16:29 UTC
Created attachment 96177 [details]
OPAC Holdings

See the red line where details are aligned to the top instead of centre.
Comment 4 Iming Chan 2019-12-11 08:18:58 UTC
Created attachment 96178 [details]
Staff client catalogue record normal view

Red lines (not all are marked) showing where field labels and field details are not quite aligned on the same level.  As well, the holdings details are aligned more towards the top than centre vertically (like OPAC holding details).
Comment 5 Iming Chan 2019-12-11 08:21:16 UTC
Sorry for the confusion, but I'm actually referring to Holdings found within each catalogue record, not the search result list.  See screen shots attached (for staff client and OPAC).

Like Owen, I agreed that the current behaviour is the best.
Comment 6 Katrin Fischer 2019-12-11 09:04:09 UTC
Ah, yes, I think it would make sense to have a look at that.
Comment 7 Katrin Fischer 2019-12-11 09:05:15 UTC
(In reply to Katrin Fischer from comment #6)
> Ah, yes, I think it would make sense to have a look at that.

= Detail page

For the holdings I am not sure. We have libraries with quit a lot of text in the note fields so it would have the same effect we saw on Owen's screenshot for the catalog results. I am happy there with the top alignment right now.
Comment 8 Katrin Fischer 2023-12-31 10:58:04 UTC
The labels in the bibliographic details now align. 
And I think we can agree to leave the holdings table as is.