Bug 11373 added change calculation to the payment page. This doesn't work very well when using the "Writeoff selected" button: - The "Amount paid" and "Change to give" fields don't make much sense in the case of writeoffs. - The amount for a partial writeoff has to be entered in the "Amount paid" field instead of the one labeled "Writeoff amount" just underneath.
Created attachment 96173 [details] [review] Bug 24208: Remove change calculation for writeoffs Bug 11373 added change calculation to the payment page. This doesn't work very well in the case of writeoffs: - The "Amount paid" and "Change to give" fields don't make much sense in the case of writeoffs. - The amount for a partial writeoff has to be entered in the "Amount paid" field instead of the one labeled "Writeoff amount" just underneath. This patch removes these unwanted fields and use the "Writeoff amount" label on the right input. Test plan: 1) Choose a patron who has fees. You can add a manual invoice if necessary. 2) Go to Accounting > Make a payment. 3) Select some fines and click "Write off selected". 4) Note the form has a lot of inputs, not all are necessary for a writeoff. 5) Make a partial writeoff by entering a different amount in the "Writeoff amount" field. => The amount written off is the amount entered in the "Amount paid" field. 6) Apply patch. 7) Repeat steps 1-3. 8) Notice the form only has "Amount outstanding", "Writeoff amount" and "Note" fields, which are enough for a writeoff. 9) Entering any amount lower than or equal to the amount outstanding in the "Writeoff amount" field should create a writeoff of the selected amount.
Comment on attachment 96173 [details] [review] Bug 24208: Remove change calculation for writeoffs Review of attachment 96173 [details] [review]: ----------------------------------------------------------------- ::: koha-tmpl/intranet-tmpl/prog/en/modules/members/paycollect.tt @@ +230,5 @@ > <span class="debit">[% total | format('%.2f') %]</span> > </li> > <li> > + [% IF type == 'WRITEOFF' %] > + <label for="paid">Writeoff amount:</label> You probably still need the trailing space here.
This looks good at a quick glance.. but perhaps we could improve it further whilst we're here. It looks me like the form title is still 'Pay an amount toward selected fines'.. we could add a switch for this too `Writeoff an amount toward selected fines` perhaps? We also still show the 'Payment types' selection dropdown unless I'm mistaken.. that could also go on a writeoff action I imagine.
Created attachment 96571 [details] [review] Bug 24208: Remove change calculation for writeoffs Bug 11373 added change calculation to the payment page. This doesn't work very well in the case of writeoffs: - The "Amount paid" and "Change to give" fields don't make much sense in the case of writeoffs. - The amount for a partial writeoff has to be entered in the "Amount paid" field instead of the one labeled "Writeoff amount" just underneath. This patch removes these unwanted fields and use the "Writeoff amount" label on the right input. Test plan: 1) Choose a patron who has fees. You can add a manual invoice if necessary. 2) Go to Accounting > Make a payment. 3) Select some fines and click "Write off selected". 4) Note the form has a lot of inputs, not all are necessary for a writeoff. 5) Make a partial writeoff by entering a different amount in the "Writeoff amount" field. => The amount written off is the amount entered in the "Amount paid" field. 6) Apply patch. 7) Repeat steps 1-3. 8) Notice the form only has "Amount outstanding", "Writeoff amount" and "Note" fields, which are enough for a writeoff. 9) Entering any amount lower than or equal to the amount outstanding in the "Writeoff amount" field should create a writeoff of the selected amount. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 96572 [details] [review] Bug 24208: (follow-up) Change page title from payment to writeoff This makes a change requested by the first tester: Also change the page title when a writeoff is done vs a payment. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 96595 [details] [review] Bug 24208: Remove change calculation for writeoffs Bug 11373 added change calculation to the payment page. This doesn't work very well in the case of writeoffs: - The "Amount paid" and "Change to give" fields don't make much sense in the case of writeoffs. - The amount for a partial writeoff has to be entered in the "Amount paid" field instead of the one labeled "Writeoff amount" just underneath. This patch removes these unwanted fields and use the "Writeoff amount" label on the right input. Test plan: 1) Choose a patron who has fees. You can add a manual invoice if necessary. 2) Go to Accounting > Make a payment. 3) Select some fines and click "Write off selected". 4) Note the form has a lot of inputs, not all are necessary for a writeoff. 5) Make a partial writeoff by entering a different amount in the "Writeoff amount" field. => The amount written off is the amount entered in the "Amount paid" field. 6) Apply patch. 7) Repeat steps 1-3. 8) Notice the form only has "Amount outstanding", "Writeoff amount" and "Note" fields, which are enough for a writeoff. 9) Entering any amount lower than or equal to the amount outstanding in the "Writeoff amount" field should create a writeoff of the selected amount. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 96596 [details] [review] Bug 24208: (follow-up) Change page title from payment to writeoff This makes a change requested by the first tester: Also change the page title when a writeoff is done vs a payment. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Nice work, Passing QA
Nice work everyone! Pushed to master for 20.05
Pushed to 19.11.x branch for 19.11.02
patchset doesn't clean apply to 19.05.x, please rebase if needed
*** Bug 24893 has been marked as a duplicate of this bug. ***