Bug 24247 - Button fixes for OPAC lists pages
Summary: Button fixes for OPAC lists pages
Status: RESOLVED DUPLICATE of bug 24706
Alias: None
Product: Koha
Classification: Unclassified
Component: OPAC (show other bugs)
Version: Main
Hardware: All All
: P5 - low trivial (vote)
Assignee: Owen Leonard
QA Contact: Testopia
URL:
Keywords:
Depends on: 24249
Blocks:
  Show dependency treegraph
 
Reported: 2019-12-15 22:02 UTC by Owen Leonard
Modified: 2020-02-28 14:43 UTC (History)
1 user (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 24247: Button fixes for OPAC lists pages (6.61 KB, patch)
2019-12-16 18:24 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 24247: Button fixes for OPAC lists pages (6.66 KB, patch)
2020-01-06 21:29 UTC, Michal Denar
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2019-12-15 22:02:16 UTC
There are some style issues with some buttons on the OPAC lists pages: Share link missing an icon, edit and delete button unstyled.
Comment 1 Owen Leonard 2019-12-16 18:24:56 UTC Comment hidden (obsolete)
Comment 2 Michal Denar 2020-01-06 21:29:30 UTC
Created attachment 96864 [details] [review]
Bug 24247: Button fixes for OPAC lists pages

This patch makes minor markup changes to the OPAC lists page so that
link and form controls are styled consistently.

To test you should have virtualshelves and OpacAllowSharingPrivateLists
enabled.

 - Apply the patch and log in to the OPAC.
 - Create a new private list.
 - When you view the list of your private lists, the "Share" link should
   have a Font Awesome icon.
 - View the contents of your list. The "Share" link in the list toolbar
   should have the same icon. The "New list" link should have a + icon.

Signed-off-by: Michal Denar <black23@gmail.com>
Comment 3 Jonathan Druart 2020-01-10 10:00:34 UTC
Blocked by bug 24249 which is not signed off yet.
Comment 4 Owen Leonard 2020-02-28 14:43:11 UTC
(In reply to Jonathan Druart from comment #3)
> Blocked by bug 24249 which is not signed off yet.

Changes were duplicated in Bug 24706.

*** This bug has been marked as a duplicate of bug 24706 ***