When receiving an order on orderreceive.pl, Koha gives one a date picker with which to change the Date Received. However, regardless of what one enters in the date picker today's date is used. To Test: - find/create an order ready for receipt - when receiving the order, set Date Received to something other than today's date - after receiving, check Receive Date in the Acquisitions tab of your bib (or query aqorders.datereceived), confirm it shows today's date I tried setting the shipment date on the invoice to something other than today, in case that made a difference, but it didn't help.
Haven't tested, but could this change the items.dateaccessioned instead?
Caused by commit 20d9ed618fbe3cdcb9c04444a1f8a584b0364069 Bug 13321: Rename variables It removed datereceived from the arguments passed to ModReceiveOrder (wrong rebase resolution conflict I suspect).
Created attachment 96611 [details] [review] Bug 24277: Fix date received editing when receiving an order Bug 8417 added the ability to edit the date received, but a merge conflict was wrongly resolved during a rebase of commit 20d9ed618fbe3cdcb9c04444a1f8a584b0364069 Bug 13321: Rename variables Test plan: Create an order Receive it Set a date (different from today) => The date you picked should have been set in DB for the order
Created attachment 96614 [details] [review] Bug 24277: Fix date received editing when receiving an order Bug 8417 added the ability to edit the date received, but a merge conflict was wrongly resolved during a rebase of commit 20d9ed618fbe3cdcb9c04444a1f8a584b0364069 Bug 13321: Rename variables Test plan: Create an order Receive it Set a date (different from today) => The date you picked should have been set in DB for the order Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>
Works for me. Thanks for the quick patch!
Comment on attachment 96614 [details] [review] Bug 24277: Fix date received editing when receiving an order Review of attachment 96614 [details] [review]: ----------------------------------------------------------------- ::: C4/Acquisition.pm @@ -1398,2 @@ > received_itemnumbers => \@received_itemnumbers, > - order_internalnote => $order_internalnote, Was this change intentional?
(In reply to Katrin Fischer from comment #6) > Comment on attachment 96614 [details] [review] [review] > Bug 24277: Fix date received editing when receiving an order > > Review of attachment 96614 [details] [review] [review]: > ----------------------------------------------------------------- > > ::: C4/Acquisition.pm > @@ -1398,2 @@ > > received_itemnumbers => \@received_itemnumbers, > > - order_internalnote => $order_internalnote, > > Was this change intentional? Yes, it's a POD update. It's not part of the param list.
(In reply to Jonathan Druart from comment #7) > (In reply to Katrin Fischer from comment #6) > > Comment on attachment 96614 [details] [review] [review] [review] > > Bug 24277: Fix date received editing when receiving an order > > > > Review of attachment 96614 [details] [review] [review] [review]: > > ----------------------------------------------------------------- > > > > ::: C4/Acquisition.pm > > @@ -1398,2 @@ > > > received_itemnumbers => \@received_itemnumbers, > > > - order_internalnote => $order_internalnote, > > > > Was this change intentional? > > Yes, it's a POD update. It's not part of the param list. Oops, sorry.
Created attachment 96993 [details] [review] Bug 24277: Regression tests Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Created attachment 96994 [details] [review] Bug 24277: Fix date received editing when receiving an order Bug 8417 added the ability to edit the date received, but a merge conflict was wrongly resolved during a rebase of commit 20d9ed618fbe3cdcb9c04444a1f8a584b0364069 Bug 13321: Rename variables Test plan: Create an order Receive it Set a date (different from today) => The date you picked should have been set in DB for the order Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Nice work everyone! Pushed to master for 20.05
Pushed to 19.11.x branch for 19.11.02
backported to 19.05.x for 19.05.08
Backported to 18.11.x for 18.11.14.