Bug 24326 - Remove advance_notices_digest.t
Summary: Remove advance_notices_digest.t
Status: In Discussion
Alias: None
Product: Koha
Classification: Unclassified
Component: Test Suite (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal (vote)
Assignee: Chris Cormack
QA Contact: Testopia
URL:
Keywords:
Depends on: 20478
Blocks:
  Show dependency treegraph
 
Reported: 2020-01-02 07:10 UTC by Katrin Fischer
Modified: 2024-01-06 10:02 UTC (History)
6 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 24326: The garbage man is your friend (7.98 KB, patch)
2021-10-06 13:21 UTC, Marcel de Rooy
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Katrin Fischer 2020-01-02 07:10:44 UTC
(In reply to Jonathan Druart from comment #26)
> There is something terribly wrong with this test file, the cronjob script is
> run outside the transaction and so changes are effective.
Comment 1 Marcel de Rooy 2021-10-06 13:21:30 UTC
Created attachment 125800 [details] [review]
Bug 24326: The garbage man is your friend
Comment 2 Marcel de Rooy 2021-10-06 13:23:04 UTC
Talking about bug titles, dcook ?
Comment 3 Jonathan Druart 2021-10-06 14:40:15 UTC
I do agree those tests should not have been pushed. 3 years later we are still missing the "clean ups could be handled separately" part.

However the tests are there and can be useful, Jenkins could back us is something is going wrong. But for devs it's really bad.

We could use the RUN_TESTS_AND_EXIT flag set by Jenkins: The tests would warn and exit early (exit 0) if the env var is not set.

Something better to suggest?
Comment 4 Katrin Fischer 2023-12-31 11:57:21 UTC
What is the issue with the tests?
Comment 5 Jonathan Druart 2024-01-04 09:09:24 UTC
See comment 0:
> the cronjob script is run outside the transaction and so changes are effective.
Comment 6 Katrin Fischer 2024-01-06 10:02:48 UTC
I didn't find any occurrence of RUN_TESTS_AND_EXIT in the codebase, so not sure if we have done similar before, but if we can make sure these are only run on by the automated tests, it would be helpful.