With strict mode enabled (tested with MariaDB 10.4.11) ERROR 1366 (22007) at line 8029: Incorrect integer value: '' for column `koha_kohadev`.`auth_subfield_structure`.`linkid` at row 769
Created attachment 96735 [details] Bug 24328: Fix bibliographic frameworks install (linkid) Had to gunzip this, otherwise I get a 413.
Count this as signed Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> If needed I can upload a gzipped signed patch, but present one it's Ok Tested enabling strict mode (MySQL), load failed before patch, load ok after patch. Comment: This field 'linkid' can be removed from the inserts, it's default value is '0' and we are inserting just that in all cases. select count(*),linkid from auth_subfield_structure group by linkid" +----------+--------+ | count(*) | linkid | +----------+--------+ | 13398 | 0 | +----------+--------+
Thx Jonathan, consider it PQA from me ;)
Created attachment 96770 [details] Zipped patch with sign-off lines
Nice work everyone! Pushed to master for 20.05
Pushed to 19.11.x branch for 19.11.02
backported to 19.05.x for 19.05.07