Bug 24400 - REST API: Checkout
Summary: REST API: Checkout
Status: RESOLVED DUPLICATE of bug 23336
Alias: None
Product: Koha
Classification: Unclassified
Component: REST API (show other bugs)
Version: Main
Hardware: All All
: P5 - low new feature (vote)
Assignee: Danyon Sewell
QA Contact:
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-01-10 22:31 UTC by Lari Taskula
Modified: 2023-05-15 07:12 UTC (History)
2 users (show)

See Also:
Change sponsored?: Sponsored
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 24400: Rest API for checkout WIP (6.12 KB, patch)
2023-05-01 04:57 UTC, Danyon Sewell
Details | Diff | Splinter Review
Bug 24400: Rest API for checkout WIP (6.21 KB, patch)
2023-05-02 02:51 UTC, Danyon Sewell
Details | Diff | Splinter Review
Bug 24400: Rest API for checkout WIP (7.66 KB, patch)
2023-05-10 04:13 UTC, Danyon Sewell
Details | Diff | Splinter Review
fixing variable (901 bytes, patch)
2023-05-10 04:18 UTC, Danyon Sewell
Details | Diff | Splinter Review
Bug 24400: Unit tests for all responses of checkout API (3.33 KB, patch)
2023-05-11 04:30 UTC, Alex Buckley
Details | Diff | Splinter Review
Bug 24400: Rest API for checkout (9.17 KB, patch)
2023-05-11 04:44 UTC, Danyon Sewell
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Lari Taskula 2020-01-10 22:31:38 UTC

    
Comment 1 Danyon Sewell 2023-05-01 04:57:46 UTC
Created attachment 150449 [details] [review]
Bug 24400: Rest API for checkout WIP
Comment 2 Danyon Sewell 2023-05-02 02:51:07 UTC
Created attachment 150495 [details] [review]
Bug 24400: Rest API for checkout WIP
Comment 3 Danyon Sewell 2023-05-10 04:13:23 UTC
Created attachment 150920 [details] [review]
Bug 24400: Rest API for checkout WIP
Comment 4 Danyon Sewell 2023-05-10 04:18:47 UTC
Created attachment 150921 [details] [review]
fixing variable
Comment 5 Alex Buckley 2023-05-11 04:30:44 UTC
Created attachment 151043 [details] [review]
Bug 24400: Unit tests for all responses of checkout API
Comment 6 Danyon Sewell 2023-05-11 04:44:34 UTC
Created attachment 151044 [details] [review]
Bug 24400: Rest API for checkout

Feature to provide API endpoints for checking out items.

To test:
1) Apply this patch
2) Run:
   $ ktd --shell
   $ prove t/db_dependent/api/v1/items.t
=> SUCCESS: Tests pass!
3. Play with item checkout using a REST tool like Postman
=> SUCCESS: All works as expected
4. Sign off :-D

Sponsored-by: Auckland University of Technology
Comment 7 Martin Renvoize 2023-05-11 07:32:23 UTC

*** This bug has been marked as a duplicate of bug 23336 ***
Comment 8 Martin Renvoize 2023-05-15 07:12:53 UTC
Apologies Danyon.. seems I missed a comment here when marking as a duplicate.

It's not always easy to spot a duplicate.. especially given in this case there were a few with long histories.  It's generally a good idea to ask questions on those with a history to help them move forward before having a fresh attemp, but I wouldn't let it hold you up too long either.

In this case, I look at the code you submitted and did a comparison before picking which to set as a duplicate.

The other bugs handles a few more cases, so I picked that one, but it also needs further development for it to fully cater for all the existing cases in the UI.  I'd love some help there and your input would be greatly appreciated.