It appears that the transition to using Koha::Item in AddReturn has introduced a bug. Previously $item was a hashref with the key 'itemtype', now that it's an object, it has no itemtype method and so triggers an error with the message "The method Koha::Item->itemtype is not covered by tests!".
Created attachment 97469 [details] [review] Bug 24441: Error when checking in an item with BranchTansferLimitsType set to itemtype It appears that the transition to using Koha::Item in AddReturn has introduced a bug. Previously $item was a hashref with the key 'itemtype', now that it's an object, it has no itemtype method and so triggers an error with the message "The method Koha::Item->itemtype is not covered by tests!". Test Plan: 1) Enable Branch Transfer Limits via itemtype 2) Check in an item 3) Note the error 4) Apply this patch 5) Restart all the things! 6) Check in an item 7) No error!
Created attachment 97513 [details] [review] Bug 24441: Error when checking in an item with BranchTansferLimitsType set to itemtype It appears that the transition to using Koha::Item in AddReturn has introduced a bug. Previously $item was a hashref with the key 'itemtype', now that it's an object, it has no itemtype method and so triggers an error with the message "The method Koha::Item->itemtype is not covered by tests!". Test Plan: 1) Enable Branch Transfer Limits via itemtype 2) Check in an item 3) Note the error 4) Apply this patch 5) Restart all the things! 6) Check in an item 7) No error! Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Maribeth (Turner) Shafer - Central Kansas Library System CKLS <mshafer@ckls.org>
Created attachment 97669 [details] [review] Bug 24441: Add tests
Created attachment 97670 [details] [review] Bug 24441: Error when checking in an item with BranchTansferLimitsType set to itemtype It appears that the transition to using Koha::Item in AddReturn has introduced a bug. Previously $item was a hashref with the key 'itemtype', now that it's an object, it has no itemtype method and so triggers an error with the message "The method Koha::Item->itemtype is not covered by tests!". Test Plan: 1) Enable Branch Transfer Limits via itemtype 2) Check in an item 3) Note the error 4) Apply this patch 5) Restart all the things! 6) Check in an item 7) No error! Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Maribeth (Turner) Shafer - Central Kansas Library System CKLS <mshafer@ckls.org>
Nice work everyone! Pushed to master for 20.05
Pushed to 19.11.x branch for 19.11.03