Bug 24451 - Clarify wording when deleting a bib attached to orders
Summary: Clarify wording when deleting a bib attached to orders
Status: NEW
Alias: None
Product: Koha
Classification: Unclassified
Component: Cataloging (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal
Assignee: Bugs List
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-01-17 14:57 UTC by Andrew Fuerste-Henry
Modified: 2021-04-06 15:29 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Andrew Fuerste-Henry 2020-01-17 14:57:03 UTC
From detail.pl, when attempting to delete a bib that is connected to any uncanceled orders in acquisitions, we receive the message: "Warning: This record is used in X order(s). Deleting it could cause serious issues on acquisition module. Are you sure you want to delete this record?"

This message would be more helpful if it distinguished between open and closed orders. Deleting a bib connected to an open order will cause serious issues. Deleting a bib connected to closed orders will not.

I see three possible fixes:
- Change the message to specify "This record is used in X open order(s) and Y closed order(s). Deleting a record used in open orders could cause serious issues ..."
- Change the message to only appear if the bib is used in orders connected to an active budget and give a count of only orders connected to an active budget.
- Complete bug 16872 to entirely block the deletion of bibs in open orders, then remove this warning. If we're not allowing the deletion of bibs from open orders, then it's not a big deal.
Comment 1 Katrin Fischer 2020-01-19 23:11:30 UTC
(In reply to Andrew Fuerste-Henry from comment #0)
> From detail.pl, when attempting to delete a bib that is connected to any
> uncanceled orders in acquisitions, we receive the message: "Warning: This
> record is used in X order(s). Deleting it could cause serious issues on
> acquisition module. Are you sure you want to delete this record?"
> 
> This message would be more helpful if it distinguished between open and
> closed orders. Deleting a bib connected to an open order will cause serious
> issues. Deleting a bib connected to closed orders will not.
> 
> I see three possible fixes:
> - Change the message to specify "This record is used in X open order(s) and
> Y closed order(s). Deleting a record used in open orders could cause serious
> issues ..."
> - Change the message to only appear if the bib is used in orders connected
> to an active budget and give a count of only orders connected to an active
> budget.
> - Complete bug 16872 to entirely block the deletion of bibs in open orders,
> then remove this warning. If we're not allowing the deletion of bibs from
> open orders, then it's not a big deal.

I am ok with the first and last suggestion, but in doubt about the 'only in active budgets'. Sometimes libraries may mark a budget form last year inactive and change the budget on receiving the item. I think differentiating between open and closed would work well enough.
Comment 2 Séverine Queune 2021-04-06 15:29:50 UTC
(In reply to Katrin Fischer from comment #1)
> (In reply to Andrew Fuerste-Henry from comment #0)
> > From detail.pl, when attempting to delete a bib that is connected to any
> > uncanceled orders in acquisitions, we receive the message: "Warning: This
> > record is used in X order(s). Deleting it could cause serious issues on
> > acquisition module. Are you sure you want to delete this record?"
> > 
> > This message would be more helpful if it distinguished between open and
> > closed orders. Deleting a bib connected to an open order will cause serious
> > issues. Deleting a bib connected to closed orders will not.
> > 
> > I see three possible fixes:
> > - Change the message to specify "This record is used in X open order(s) and
> > Y closed order(s). Deleting a record used in open orders could cause serious
> > issues ..."
> > - Change the message to only appear if the bib is used in orders connected
> > to an active budget and give a count of only orders connected to an active
> > budget.
> > - Complete bug 16872 to entirely block the deletion of bibs in open orders,
> > then remove this warning. If we're not allowing the deletion of bibs from
> > open orders, then it's not a big deal.
> 
> I am ok with the first and last suggestion, but in doubt about the 'only in
> active budgets'. Sometimes libraries may mark a budget form last year
> inactive and change the budget on receiving the item. I think
> differentiating between open and closed would work well enough.

+1 for Katrin, that's extactly our workflow, we change budget only on receipt.