Checking bug 7468 I noticed that all the templates in labels use the catalogue permission instead of the expected tools->label_creator permission. The permission description manages creating labels from patron and catalog data, so it seems it should be used for the label creator?
Can you clarify this one? It looks to me like the template for ./koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/cataloging-home.tt uses the correct tools label creator sub-permission. However, it looks like the Perl scripts (e.g. ./labels/label-home.pl) are using the "catalogue" permission instead. Actually running 'grep "flagsrequired" ./labels/*' shows either "catalogue => 1" or "tools => 'label_creator'" or "borrowers => 'edit_borrowers'" I wonder if the Perl scripts should have both the "label_creator" sub permission and the "catalogue" permission...
It seems correct to update all the label-*.pl script to require "label_creator" permission. My only hesitation is about the quick spine label print option. If you have SpineLabelShowPrintOnBibDetails enabled the bibliographic detail page's holdings table has a column with "Print label" buttons. There is currently no permissions check on that. Should we add a "label_creator" permission check to that button and the corresponding page, or should we leave that one available to users with only "catalogue" permission?
I feel like it should be separate? It's not necessarily the same people who print patron cards and who print item labels. Especially now that the item labels have been moved in cataloging instead of tools.