Bug 24465 - Label creator requires catalogue permission instead of label_creator permission from tools
Summary: Label creator requires catalogue permission instead of label_creator permissi...
Status: NEW
Alias: None
Product: Koha
Classification: Unclassified
Component: Label/patron card printing (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal (vote)
Assignee: Chris Nighswonger
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-01-20 21:31 UTC by Katrin Fischer
Modified: 2022-11-02 00:41 UTC (History)
1 user (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Katrin Fischer 2020-01-20 21:31:16 UTC
Checking bug 7468 I noticed that all the templates in labels use the catalogue permission instead of the expected tools->label_creator permission.

The permission description manages creating labels from patron and catalog data, so it seems it should be used for the label creator?
Comment 1 David Cook 2022-11-02 00:41:27 UTC
Can you clarify this one?

It looks to me like the template for ./koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/cataloging-home.tt uses the correct tools label creator sub-permission.

However, it looks like the Perl scripts (e.g. ./labels/label-home.pl) are using the "catalogue" permission instead.

Actually running 'grep "flagsrequired" ./labels/*' shows either "catalogue => 1" or "tools => 'label_creator'" or "borrowers => 'edit_borrowers'"

I wonder if the Perl scripts should have both the "label_creator" sub permission and the "catalogue" permission...