Bug 24465 - Label creator requires catalogue permission instead of label_creator permission from tools
Summary: Label creator requires catalogue permission instead of label_creator permissi...
Status: NEW
Alias: None
Product: Koha
Classification: Unclassified
Component: Label/patron card printing (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal
Assignee: Chris Nighswonger
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-01-20 21:31 UTC by Katrin Fischer
Modified: 2025-08-11 18:11 UTC (History)
2 users (show)

See Also:
GIT URL:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Katrin Fischer 2020-01-20 21:31:16 UTC
Checking bug 7468 I noticed that all the templates in labels use the catalogue permission instead of the expected tools->label_creator permission.

The permission description manages creating labels from patron and catalog data, so it seems it should be used for the label creator?
Comment 1 David Cook 2022-11-02 00:41:27 UTC
Can you clarify this one?

It looks to me like the template for ./koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/cataloging-home.tt uses the correct tools label creator sub-permission.

However, it looks like the Perl scripts (e.g. ./labels/label-home.pl) are using the "catalogue" permission instead.

Actually running 'grep "flagsrequired" ./labels/*' shows either "catalogue => 1" or "tools => 'label_creator'" or "borrowers => 'edit_borrowers'"

I wonder if the Perl scripts should have both the "label_creator" sub permission and the "catalogue" permission...
Comment 2 Owen Leonard 2025-08-11 17:51:34 UTC
It seems correct to update all the label-*.pl script to require "label_creator" permission.

My only hesitation is about the quick spine label print option. If you have SpineLabelShowPrintOnBibDetails enabled the bibliographic detail page's holdings table has a column with "Print label" buttons. There is currently no permissions check on that.

Should we add a "label_creator" permission check to that button and the corresponding page, or should we leave that one available to users with only "catalogue" permission?
Comment 3 Caroline Cyr La Rose 2025-08-11 18:11:58 UTC
I feel like it should be separate? It's not necessarily the same people who print patron cards and who print item labels. Especially now that the item labels have been moved in cataloging instead of tools.