During rebases of the cash registers feature added in bug 23321 it appears that one case of a changed permission name was missed in admin/cash_registers.pl.
Created attachment 97731 [details] [review] Bug 24481: Correct permission name for cash registers The permission name for changed during the implimentation of bug 23321 but one case was missed. This patch corrects that mistake.
Marking as signed off to go straight to QA as it's a minor but important change.. I would have done it as an RM follow-up but as it needs backporting to 19.11 it's sensible to give it it's own bug
Created attachment 97734 [details] [review] Bug 24481: Correct permission name for cash registers The permission name for changed during the implimentation of bug 23321 but one case was missed. This patch corrects that mistake. Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Easy fix, simple change, SO+QA
Created attachment 97738 [details] [review] Bug 24481: Move manage_cash_registers to parameters permission This patch moves the manage_cash_registers subpermission to the more appropriate location under 'parameters'.
Created attachment 97739 [details] [review] Bug 24481: Correct permission name in admin/cash_registers.pl The permission name for changed during the implimentation of bug 23321 but one case was missed. This patch corrects that mistake.
Created attachment 97740 [details] [review] Bug 24481: Permission corrections for admin menu templates This patch updates the admin menu include and admin home page to reflect the updated permissions name for cash registers
Created attachment 97741 [details] [review] Bug 24481: Permissions update for POS menu include This patch updates the point of sale menu include to reflect the updated permissions name for cash registers Note: Not required for 19.11
Only the final patch depends on 23354 and this patch should not be backported to 19.11
Created attachment 97756 [details] [review] Bug 24481: Permissions update for POS menu include This patch updates the point of sale menu include to reflect the updated permissions name for cash registers Note: Not required for 19.11 Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 97757 [details] [review] Bug 24481: Move manage_cash_registers to parameters permission This patch moves the manage_cash_registers subpermission to the more appropriate location under 'parameters'. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 97758 [details] [review] Bug 24481: Correct permission name in admin/cash_registers.pl The permission name for changed during the implimentation of bug 23321 but one case was missed. This patch corrects that mistake. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 97759 [details] [review] Bug 24481: Permission corrections for admin menu templates This patch updates the admin menu include and admin home page to reflect the updated permissions name for cash registers Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 97760 [details] [review] Bug 24481: Permissions update for POS menu include This patch updates the point of sale menu include to reflect the updated permissions name for cash registers Note: Not required for 19.11 Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Nice work everyone! Pushed to master for 20.05
not backported to 19.11.x