Created attachment 97749 [details] duplicate language When a patron is logged into the OPAC and views their Fines tab- they will see a description of the Fine duplicated. For example: Credit (Voided) (Voided) Fine (Accruing) (Acrruing) Payment (Voided) (Voided) Attaching a screenshot. It is not necessary and could be confusing to the patron to have this duplicated per line.
Caused by commit efc21e6f47801503e55e3ba709a48c3f426f90ac Bug 23115: (follow-up) Move switches to a TT block
Created attachment 97883 [details] [review] Bug 24486: Remove duplicated account information at the OPAC commit efc21e6f47801503e55e3ba709a48c3f426f90ac Bug 23115: (follow-up) Move switches to a TT block Duplicated the following line: + [% PROCESS account_type_description account=ACCOUNT_LINE %] [%- PROCESS account_status_description account=ACCOUNT_LINE -%] Which cause the info to appear twice Test plan: Create a manual invoice Pay it Void it Go to the opac, account => You should see only one "(Voided)"
Hi Jonathan, Yes I only see one one "(Voided)" but in some cases (when payment has not been voided) I see nothing at all. I could be wrong but shouldn't it be 'account_status_description' that is deleted and 'account_type_description' that should stay? Thank you.
Created attachment 97894 [details] [review] Bug 24486: Remove duplicated account information at the OPAC commit efc21e6f47801503e55e3ba709a48c3f426f90ac Bug 23115: (follow-up) Move switches to a TT block Duplicated the following line: + [% PROCESS account_type_description account=ACCOUNT_LINE %] [%- PROCESS account_status_description account=ACCOUNT_LINE -%] Which cause the info to appear twice Test plan: Create a manual invoice Pay it Void it Go to the opac, account => You should see only one "(Voided)" Signed-off-by: Christofer Zorn <christofer.zorn@ajaxlibrary.ca>
Followed test plan and was able to duplicate the error. After applying the patch, the duplication of text was no longer there. Christofer
(In reply to Lucas Gass from comment #3) > Hi Jonathan, > > Yes I only see one one "(Voided)" but in some cases (when payment has not > been voided) I see nothing at all. > > I could be wrong but shouldn't it be 'account_status_description' that is > deleted and 'account_type_description' that should stay? > > > Thank you. Ho you are right Lucas, the lines are not the same! Then I do not know how to correctly fix this issue. Martin or Nick may know.
Created attachment 97961 [details] [review] Bug 24486: Remove duplicated account information at the OPAC Test plan: Create a manual invoice Pay it Void it Go to the opac, account => You should see only one "(Voided)"
I think I finally found the proper fix.
Created attachment 97971 [details] [review] Bug 24486: Remove duplicated account information at the OPAC Test plan: Create a manual invoice Pay it Void it Go to the opac, account => You should see only one "(Voided)" Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Good catch, trivial fix.. works as expected, Passing QA
Created attachment 97973 [details] [review] Bug 24486: Alternate Test plan: Create a manual invoice Pay it Void it Go to the opac, account => You should see only one "(Voided)"
Nice work everyone! Pushed to master for 20.05
Pushed to 19.11.x branch for 19.11.03
backported to 19.05.x for 19.05.08
Dependency not in 18.11.x, not backporting to 18.11.x series.