In the Patron set of the Column Configuration under Pay-Fines-Table, checking to hide the "account type" field does not hide the "Account Type" in pay.pl. If "Account Type" and "Description" are both chosen, it will hide the "account type" in pay.pl but not the "description".
Created attachment 97931 [details] [review] Bug 24515: Column Configuration for pay-fines-table does not hide Account Type properly This patch corrects the order of the columns in the columns configuration YML file. The incorrect order was causing the wrong column to be hidden when changing the columns settings for the table in Administration. To test, apply the patch and go to Administration -> Columns settings. - Under Patrons -> pay-fines-table, test hiding the account_type and description columns, together and separately. - Verify that the correct columns are hidden on the pay fines screen (Patron -> Accounting -> Make a payment)
Created attachment 97933 [details] [review] Bug 24515: Column Configuration for pay-fines-table does not hide Account Type properly This patch corrects the order of the columns in the columns configuration YML file. The incorrect order was causing the wrong column to be hidden when changing the columns settings for the table in Administration. To test, apply the patch and go to Administration -> Columns settings. - Under Patrons -> pay-fines-table, test hiding the account_type and description columns, together and separately. - Verify that the correct columns are hidden on the pay fines screen (Patron -> Accounting -> Make a payment) Signed-off-by: David Nind <david@davidnind.com>
Created attachment 97940 [details] [review] Bug 24515: Column Configuration for pay-fines-table does not hide Account Type properly This patch corrects the order of the columns in the columns configuration YML file. The incorrect order was causing the wrong column to be hidden when changing the columns settings for the table in Administration. To test, apply the patch and go to Administration -> Columns settings. - Under Patrons -> pay-fines-table, test hiding the account_type and description columns, together and separately. - Verify that the correct columns are hidden on the pay fines screen (Patron -> Accounting -> Make a payment) Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Nice work everyone! Pushed to master for 20.05
Pushed to 19.11.x for 19.11.03
backported to 19.05.x. for 19.05.08