A patron's ILL requests are not displaying on the "ILL requests history" tab on their profile page on intranet. This is due to a check in ill-list-table.js that checks what page the user is on before sending the API request to get the requests. This check was added in bug 23229. I failed to realise that it adversely affected the patron profile page in this way. I will create a fix now.
Created attachment 98281 [details] [review] Bug 24565: Add patron profile to ILL list pages We need the API call to get ILL requests on the patron profile page, this commit allows this. Test plan: - Do not apply the patch. - Go to the "Ill requests history" page for a patron who has made ILL requests - TEST: Observe that no requests are displayed - Apply the patch - Refresh the page - TEST: Observe that requests are displayed - Go to the main "ILL requests" page - TEST: Observe that requests are displayed
Created attachment 100414 [details] [review] Bug 24565: Add patron profile to ILL list pages We need the API call to get ILL requests on the patron profile page, this commit allows this. Test plan: - Do not apply the patch. - Go to the "Ill requests history" page for a patron who has made ILL requests - TEST: Observe that no requests are displayed - Apply the patch - Refresh the page - TEST: Observe that requests are displayed - Go to the main "ILL requests" page - TEST: Observe that requests are displayed Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 100548 [details] [review] Bug 24565: Add patron profile to ILL list pages We need the API call to get ILL requests on the patron profile page, this commit allows this. Test plan: - Do not apply the patch. - Go to the "Ill requests history" page for a patron who has made ILL requests - TEST: Observe that no requests are displayed - Apply the patch - Refresh the page - TEST: Observe that requests are displayed - Go to the main "ILL requests" page - TEST: Observe that requests are displayed Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Clear and trivial code fix.. Passing QA
Nice work everyone! Pushed to master for 20.05
Backported to 19.11.x branch for 19.11.05
backported to 19.05.x for 19.05.10
The file that this patch affects does not appear to exist in 18.11.x, not backporting for now - if someone is able to test if this is an issue for 18.11.x I would appreciate it, as I'm struggling to get ILL in a testable state at the moment