As far as I can make out, the `StoreLastBorrower` preference is available to allow staff to track down who may have returned an item last when said item is found to be damaged or lost even when privacy policy or patron privacy settings are set to anonymize checkout history. As such, I feel this setting would be better placed under the `Circulation`, `Logs` or `Staff client` tabs with a clearer explanation for it's use.
Created attachment 98990 [details] [review] Bug 24576: `StoreLastBorrower` preference is in the wrong tab and is confusing This patch moves the preference from OPAC/Privacy to Circulation/Check In To Test: 1) Apply the patch 2) Check that the system preference no longer displays under the OPAC Privacy tab 3) Check that it now displays in the Circulation tab, under the Check In policy 4) Ensure that the system preference can be changed and saved correctly.
I feel that any clarification to the use of this system preference would be better documented in more / greater detail in the manual, rather than in the system preference itself so I haven't changed the description at all.
Created attachment 99001 [details] [review] Bug 24576: `StoreLastBorrower` preference is in the wrong tab and is confusing This patch moves the preference from OPAC/Privacy to Circulation/Check In To Test: 1) Apply the patch 2) Check that the system preference no longer displays under the OPAC Privacy tab 3) Check that it now displays in the Circulation tab, under the Check In policy 4) Ensure that the system preference can be changed and saved correctly. Signed-off-by: Liz Rea <wizzyrea@gmail.com>
Created attachment 99056 [details] [review] Bug 24576: `StoreLastBorrower` preference is in the wrong tab and is confusing This patch moves the preference from OPAC/Privacy to Circulation/Check In To Test: 1) Apply the patch 2) Check that the system preference no longer displays under the OPAC Privacy tab 3) Check that it now displays in the Circulation tab, under the Check In policy 4) Ensure that the system preference can be changed and saved correctly. Signed-off-by: Liz Rea <wizzyrea@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Makes much more sense, thx!
Nice work everyone! Pushed to master for 20.05
enhancement not pushed to 19.11.x