When patron messaging preferences are selected not to send courtesy notices, and there is no email for them to be sent to, Koha generates a notice and marks it as failed. The case I'm specifically looking at involves Auto Renewal notices. These “failures” are visible in the Patron Notices Log and then general circulation staff sees “failed” and gets confused. Staff education is important, but we can make things easier for our users by clarifying these types of messages. Either we could skip making them, as determined the Patron messaging preferences, to find a better status term for these types of messages. "Not applicable" "Unsent" "Not required" "No emails selected"
I'd vote for not generating notices in this case - if a patron has opted out of receiving notices by not adding an email address, we should not generate any. I think it doesn't generate emails for all notices, would you object to make this about the auto-renewal notice for now and change the bug description accordingly?