Bug 24704 - Conditionally loading BakerTaylor modules can cause problems in persistent environment (Plack)
Summary: Conditionally loading BakerTaylor modules can cause problems in persistent en...
Status: RESOLVED DUPLICATE of bug 17896
Alias: None
Product: Koha
Classification: Unclassified
Component: OPAC (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal (vote)
Assignee: Nick Clemens
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-02-21 12:35 UTC by Nick Clemens
Modified: 2020-02-27 18:44 UTC (History)
0 users

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 24704: load BakerTaylor module with use (5.10 KB, patch)
2020-02-21 13:02 UTC, Nick Clemens
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Nick Clemens 2020-02-21 12:35:31 UTC

    
Comment 1 Nick Clemens 2020-02-21 13:02:47 UTC
Created attachment 99371 [details] [review]
Bug 24704: load BakerTaylor module with use

We are incinsistent here, Amazon and Syndetics module are always loaeded in some places
BakerTaylor is conditional everywhere, and causes issues under plack

For simplicity sake I think we should just load this (small) module where it might be needed

To test:
1 - Disable Baker and Taylor images
2 - Restart plack
3 - Visit opac-readingrecord, opac-detail, opac-search, opac-shelves, opac-user
    Log in to opac
    Virew your reading history
    Make/view a list
    Search the catalog
    Look at an individual title
4 - Enable BakerTaylorEnabled
    If you don't have Baker and Taylor credentials, simply fudge them with bad data and enable
5 - Repeat steps above, in the word of Joubu "Kaboom"
6 - Apply patch
7 - Repeat 1-4
8 - You shoudl be able to load all the pages after enabling the pref
Comment 2 Nick Clemens 2020-02-21 13:10:18 UTC

*** This bug has been marked as a duplicate of bug 17896 ***