Catalogers would like to visually see if there is a space after the delimiter in the Advanced editor, much like what was done for Bug 24452 - Advanced editor - show multiple spaces visually
Created attachment 99429 [details] [review] Bug 24709: Advanced editor - show space after delimiter visually This patch updates the JavaScript and CSS for the advanced MARC editor so that a space immediately following a delimiter will be detected and highlighted (green). To test the EnableAdvancedCatalogingEditor system preference should be enabled. Apply the patch and clear your browser cache if necessary. - Go to Cataloging -> Advanced editor. - On any text entry line (e.g. 245), add a space immediately following the delimiter the space and delimiter should be highlighted green. - Remove the extra space and confirm that the highlight disappears.
Assigning to me.
Created attachment 99444 [details] [review] Bug 24709: Advanced editor - show space after delimiter visually This patch updates the JavaScript and CSS for the advanced MARC editor so that a space immediately following a delimiter will be detected and highlighted (green). To test the EnableAdvancedCatalogingEditor system preference should be enabled. Apply the patch and clear your browser cache if necessary. 1) Go to Cataloging -> Advanced editor. 2) On any text entry line (e.g. 245), add a space immediately following the delimiter the space and delimiter should be highlighted green. 3) Remove the extra space and confirm that the highlight disappears. Signed-off-by: David Nind <david@davidnind.com>
I totally agree with the idea of this, I am just wondering if the green highlighting works in terms of usability (easy to understand, what the problem is as green is usually a 'good thing') I wonder if some red underlining would work better, thinking about how text processors like Word inform you of things to fix. Adding Owen for an additional opinion. (Don't be scared by status change, I will come back to this!)
The green was our head of cataloging choice. There's already red dotted lines for two spaces.
I agree with Katrin that green so often means good that it would be confusing. I checked in word and libreoffice and they both did blue underline for grammar errors. Maybe a blue highlight or underline would work here as well? Lisette
I'm good with highlight blue. We'd like this to be a bit more prominent than underline, as it's an insidious problem and common for people converting from OCLC
Created attachment 100080 [details] [review] Bug 24709: Advanced editor - show space after delimiter visually This patch updates the JavaScript and CSS for the advanced MARC editor so that a space immediately following a delimiter will be detected and highlighted (green). To test the EnableAdvancedCatalogingEditor system preference should be enabled. Apply the patch and clear your browser cache if necessary. - Go to Cataloging -> Advanced editor. - On any text entry line (e.g. 245), add a space immediately following the delimiter the space and delimiter should be highlighted green. - Remove the extra space and confirm that the highlight disappears.
Created attachment 100081 [details] [review] Bug 24709: Advanced editor - show space after delimiter visually This patch updates the JavaScript and CSS for the advanced MARC editor so that a space immediately following a delimiter will be detected and highlighted (green). To test the EnableAdvancedCatalogingEditor system preference should be enabled. Apply the patch and clear your browser cache if necessary. - Go to Cataloging -> Advanced editor. - On any text entry line (e.g. 245), add a space immediately following the delimiter the space and delimiter should be highlighted green. - Remove the extra space and confirm that the highlight disappears. Signed-off-by: David Nind <david@davidnind.com>
Bug 24709: Advanced editor - show space after delimiter visually This patch updates the JavaScript and CSS for the advanced MARC editor so that a space immediately following a delimiter will be surrounded by a red dotted border. To test the EnableAdvancedCatalogingEditor system preference should be enabled. Apply the patch and clear your browser cache if necessary. - Go to Cataloging -> Advanced editor. - On any text entry line (e.g. 245), add a space immediately following the **delimiter the space and delimiter should be surrounded by a red dotted border. - Remove the extra space and confirm that the red dotted border is removed **To create a delimiter in the advanced editor, go to a non-control field (after 010) and hit the control button with the letter "d" then enter any letter or single digit.
Created attachment 100082 [details] [review] Bug 24709: Advanced editor - show space after delimiter visually This patch updates the JavaScript and CSS for the advanced MARC editor so that a space immediately following a delimiter will be surrounded by a red dotted border. To test the EnableAdvancedCatalogingEditor system preference should be enabled. Apply the patch and clear your browser cache if necessary. - Go to Cataloging -> Advanced editor. - On any text entry line (e.g. 245), add a space immediately following the **delimiter the space and delimiter should be surrounded by a red dotted border. - Remove the extra space and confirm that the red dotted border is removed **To create a delimiter in the advanced editor, go to a non-control field (after 010) and hit the control button with the letter "d" then enter any letter or single digit.
Issues with my vm space is causing this not to work :(
Created attachment 114079 [details] [review] Bug 24709: Advanced editor - show space after delimiter visually This patch updates the JavaScript and CSS for the advanced MARC editor so that a space immediately following a delimiter will be surrounded by an orange dotted border. To test the EnableAdvancedCatalogingEditor system preference should be enabled. Apply the patch and clear your browser cache if necessary. - Go to Cataloging -> Advanced editor. - On any text entry line (e.g. 245), add a space immediately following the **delimiter the space and delimiter should be surrounded by a red dotted border. - Remove the extra space and confirm that the red dotted border is removed **To create a delimiter in the advanced editor, go to a non-control field (after 010) and hit the control button with the letter "d" then enter any letter or single digit.
Created attachment 114080 [details] Correct Ubuntu versions in release notes - md Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
This patch updates the JavaScript and CSS for the advanced MARC editor so that a space immediately following a delimiter will be surrounded by an orange dotted border. To test the EnableAdvancedCatalogingEditor system preference should be enabled. Apply the patch and clear your browser cache if necessary. - Go to Cataloging -> Advanced editor. - On any text entry line (e.g. 245), add a space immediately following the **delimiter the space and delimiter should be surrounded by a red dotted border. - Remove the extra space and confirm that the red dotted border is removed **To create a delimiter in the advanced editor, go to a non-control field (after 010) and hit the control button with the letter "d" then enter any letter or single digit.
My test produced the orange dotted border for some subfields but not all of them. For instance, it did not work for the subfield 'a' of a 100 or 245 tag. Also, it did not work when a tag had only one subfield and it was not subfield 'a'.
Created attachment 115216 [details] Orange border missing for some subfields