Bug 24796 - No test coverage for getting translations from templates
Summary: No test coverage for getting translations from templates
Status: NEW
Alias: None
Product: Koha
Classification: Unclassified
Component: I18N/L10N (show other bugs)
Version: master
Hardware: All All
: P5 - low normal (vote)
Assignee: Bugs List
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-03-04 09:51 UTC by paxed
Modified: 2020-03-04 09:51 UTC (History)
1 user (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Text to go in the release notes:
Version(s) released in:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description paxed 2020-03-04 09:51:44 UTC
There are two different code paths for getting translatable strings out of templates: 1) extract_messages_from_templates() in LangInstaller.pm which handles js-files and the templates that use i18n.inc, 2) tmpl_process3.pl which uses misc/translation/xgettext.pl to parse and extract strings out of tt-files.

The t/LangInstaller.t only tests the first one, there are no tests whatsoever for the second.