script and template selectbranchprinter[.pl|.tt] should be renamed. Bug 17845 removed the branchprinter feature, so the script should be named select_library or equivalent.
Created attachment 100715 [details] [review] Bug 24837: Rename selectbranchprinter.pl to set-library.pl This renames the selectbranchprinter.pl file to the more fitting set-library.pl. To test: - Change the library with "Set library" from - The menu in the top navigation bar - The circulation start page - Verify the help link on page leads to the correct section in the manual - Read the code... and verify all occurences have been caught
Created attachment 101371 [details] [review] Bug 24837: Rename selectbranchprinter.pl to set-library.pl This renames the selectbranchprinter.pl file to the more fitting set-library.pl. To test: - Change the library with "Set library" from - The menu in the top navigation bar - The circulation start page - Verify the help link on page leads to the correct section in the manual - Read the code... and verify all occurences have been caught Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Works ok, fixed tab char in circ/branchtransfers.pl
Created attachment 101457 [details] [review] Bug 24837: Rename selectbranchprinter.pl to set-library.pl This renames the selectbranchprinter.pl file to the more fitting set-library.pl. To test: - Change the library with "Set library" from - The menu in the top navigation bar - The circulation start page - Verify the help link on page leads to the correct section in the manual - Read the code... and verify all occurences have been caught Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Works ok, fixed tab char in circ/branchtransfers.pl Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Thanks for grabbing this one :)
Nice work everyone! Pushed to master for 20.05
not backported to 19.11.x