Clicking the help button from various points within label-manage.pl takes one to the patron card creator area of the manual. It should point to the relevant label bits instead.
Created attachment 100714 [details] [review] Bug 24848: Improve manual links for the label creator Some of the manual links in the label creator tool were not working correctly or pointing to the wrong pages. A problem is the label-manage.pl file. This can show different data depending on an added parameter. Example: /cgi-bin/koha/labels/label-manage.pl?label_element=template But it appears that parameters will be ignored when creating links to the manual. So this patch links to the beginning of the label creator section in the manual for now. To test: - Go to the lable creator - Try the various pages of the tool - Note: All 'New ...' links should point to the correct section in the manual (batches, templates, ...) Except: Barcode range. This feature is new and not yet documented in the manual. Link goes to label creator section. - Note: All 'Manage ...' links should point to the beginning of the 'label creator' section in the manual
The solution is not perfect - label-manage.pl is a problem still (see patch description).
Sorry Andrew for stealing this one - noticed too late. :(
Not a problem at all! Thanks for the patch!
Created attachment 100899 [details] [review] Bug 24848: Improve manual links for the label creator Some of the manual links in the label creator tool were not working correctly or pointing to the wrong pages. A problem is the label-manage.pl file. This can show different data depending on an added parameter. Example: /cgi-bin/koha/labels/label-manage.pl?label_element=template But it appears that parameters will be ignored when creating links to the manual. So this patch links to the beginning of the label creator section in the manual for now. To test: - Go to the lable creator - Try the various pages of the tool - Note: All 'New ...' links should point to the correct section in the manual (batches, templates, ...) Except: Barcode range. This feature is new and not yet documented in the manual. Link goes to label creator section. - Note: All 'Manage ...' links should point to the beginning of the 'label creator' section in the manual Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>
Created attachment 101108 [details] [review] Bug 24848: Improve manual links for the label creator Some of the manual links in the label creator tool were not working correctly or pointing to the wrong pages. A problem is the label-manage.pl file. This can show different data depending on an added parameter. Example: /cgi-bin/koha/labels/label-manage.pl?label_element=template But it appears that parameters will be ignored when creating links to the manual. So this patch links to the beginning of the label creator section in the manual for now. To test: - Go to the lable creator - Try the various pages of the tool - Note: All 'New ...' links should point to the correct section in the manual (batches, templates, ...) Except: Barcode range. This feature is new and not yet documented in the manual. Link goes to label creator section. - Note: All 'Manage ...' links should point to the beginning of the 'label creator' section in the manual Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Created attachment 101110 [details] [review] Bug 24848: Improve manual links for the label creator Some of the manual links in the label creator tool were not working correctly or pointing to the wrong pages. A problem is the label-manage.pl file. This can show different data depending on an added parameter. Example: /cgi-bin/koha/labels/label-manage.pl?label_element=template But it appears that parameters will be ignored when creating links to the manual. So this patch links to the beginning of the label creator section in the manual for now. To test: - Go to the lable creator - Try the various pages of the tool - Note: All 'New ...' links should point to the correct section in the manual (batches, templates, ...) Except: Barcode range. This feature is new and not yet documented in the manual. Link goes to label creator section. - Note: All 'Manage ...' links should point to the beginning of the 'label creator' section in the manual Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Kyle: we're clashing now
Nice work everyone! Pushed to master for 20.05
backported to 19.11.x for 19.11.05
backported to 19.05.x for 19.05.10
Not an issue in 18.11, not backporting to 18.11.x series.