When using 'order from a subscription', acquisition details will show in the serials module on the subscription detail page. The basketnumber is linked, but the URL is broken: http://localhost:8081/cgi-bin/koha/acqui/basket.pl?basketno= It's missing the basketno parameter.
Created attachment 102029 [details] [review] Bug 24941: Serials - Fix link to basket from acquisition details information Adding orders from subscriptions makes acquisition information visible in the serials module. In the table of acquisition data is a link back to the basket - but this link is missing the basket number parameter - it doesn't work. This patch fixes the TT variable to make it work. To test: - Add a subscription - Add a new basket - Add a order line using "Add from subscription" - Go to the subscription details page, check the acquisitions tab - Try the link to the basket - it should not work - Apply patch - Try the link again - now it should bring up the basket page with the order.
Created attachment 102103 [details] [review] Bug 24941: Serials - Fix link to basket from acquisition details information Adding orders from subscriptions makes acquisition information visible in the serials module. In the table of acquisition data is a link back to the basket - but this link is missing the basket number parameter - it doesn't work. This patch fixes the TT variable to make it work. To test: - Add a subscription - Add a new basket - Add a order line using "Add from subscription" - Go to the subscription details page, check the acquisitions tab - Try the link to the basket - it should not work - Apply patch - Try the link again - now it should bring up the basket page with the order. Signed-off-by: David Nind <david@davidnind.com>
Notes for testing (mainly as I'm not that familiar with acquisitions or serials): - An example of the page where the link is not working correctly is for example (using koha-testing-docker): http://127.0.0.1:8081/cgi-bin/koha/serials/subscription-detail.pl?subscriptionid=1 - Replace the subscriptionid number with one you have setup.
Caused by commit 679930c8597680a870f7c9801b6dbd40e1254edf Bug 21467: Display a summary line per parent_ordernumber
Created attachment 102130 [details] [review] Bug 24941: Serials - Fix link to basket from acquisition details information Adding orders from subscriptions makes acquisition information visible in the serials module. In the table of acquisition data is a link back to the basket - but this link is missing the basket number parameter - it doesn't work. This patch fixes the TT variable to make it work. To test: - Add a subscription - Add a new basket - Add a order line using "Add from subscription" - Go to the subscription details page, check the acquisitions tab - Try the link to the basket - it should not work - Apply patch - Try the link again - now it should bring up the basket page with the order. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Nice work everyone! Pushed to master for 20.05
backported to 19.11.x branch for 19.11.06