In the table of saved reports the number in the 'ID' column is wrapped in a <label> tag, but clicking it doesn't check the corresponding checkbox because the "for" attribute doesn't match the ID of the checkbox.
Created attachment 101495 [details] [review] Bug 24959: Fix id/label pairs in saved reports table This patch adds a unique id attribute to each checkbox in the table of saved reports. Also updated is the corresponding <label>'s "for" attribute so that clicking the report id will toggle the checkbox. To reproduce, go to Reports -> Use saved and click a number in the ID column. Nothing happens. After applying the patch clicking the number should check or uncheck the corresponding checkbox.
Created attachment 101538 [details] [review] Bug 24959: Fix id/label pairs in saved reports table This patch adds a unique id attribute to each checkbox in the table of saved reports. Also updated is the corresponding <label>'s "for" attribute so that clicking the report id will toggle the checkbox. To reproduce, go to Reports -> Use saved and click a number in the ID column. Nothing happens. After applying the patch clicking the number should check or uncheck the corresponding checkbox. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Works Ok, no errors.
Created attachment 101540 [details] [review] Bug 24541: Purge old messages misc/cronjobs/cleanup_database.pl provides some database cleanup. This patch adds cleanup for messages table. Test plan : - Count messages : select count(*),date(message_date) from messages group by date(message_date); - Run cleanup : misc/cronjobs/cleanup_database.pl -v --messages 365 - Recount messages Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Works Ok, no errors.
Comment on attachment 101540 [details] [review] Bug 24541: Purge old messages Sorry, wrong bug
Created attachment 101767 [details] [review] Bug 24959: Fix id/label pairs in saved reports table This patch adds a unique id attribute to each checkbox in the table of saved reports. Also updated is the corresponding <label>'s "for" attribute so that clicking the report id will toggle the checkbox. To reproduce, go to Reports -> Use saved and click a number in the ID column. Nothing happens. After applying the patch clicking the number should check or uncheck the corresponding checkbox. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Works Ok, no errors. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Nice work everyone! Pushed to master for 20.05
not backported due to dependencies