Bug 24962 - Don't show floating toolbar when duplicate patron record was detected
Summary: Don't show floating toolbar when duplicate patron record was detected
Status: Pushed to master
Alias: None
Product: Koha
Classification: Unclassified
Component: Patrons (show other bugs)
Version: master
Hardware: All All
: P5 - low normal (vote)
Assignee: Jonathan Druart
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-03-24 07:56 UTC by Katrin Fischer
Modified: 2020-04-03 21:58 UTC (History)
6 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Who signed the patch off:
Text to go in the release notes:
Version(s) released in:
20.05.00


Attachments
Bug 24962: Do not display the toolbar when editing a patron and dup is found (2.04 KB, patch)
2020-03-24 08:43 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 24962: Do not display the toolbar when editing a patron and dup is found (2.12 KB, patch)
2020-03-24 10:07 UTC, PTFS Europe Sandboxes
Details | Diff | Splinter Review
Bug 24962: Do not display the toolbar when editing a patron and dup is found (2.17 KB, patch)
2020-03-24 10:13 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Katrin Fischer 2020-03-24 07:56:52 UTC
When you create a new patron with the same information than an existing patron, you will get a duplicate message (the name matching will be usually enough). If the duplicate message appears, the floating toolbar gets pushed further to the top and the buttons cannot be clicked.
Comment 1 Jonathan Druart 2020-03-24 08:43:00 UTC
Created attachment 101508 [details] [review]
Bug 24962: Do not display the toolbar when editing a patron and dup is found

Whe a duplicate patron is found, the toolbar to save is display without
the button.
We must hide it completely, user has to use the 2 buttons from the dup
message "Editing existing" or "Save as new".
Comment 2 Katrin Fischer 2020-03-24 08:43:54 UTC
You caught me - I was missing the point :)
Comment 3 PTFS Europe Sandboxes 2020-03-24 10:07:32 UTC
Created attachment 101530 [details] [review]
Bug 24962: Do not display the toolbar when editing a patron and dup is found

Whe a duplicate patron is found, the toolbar to save is display without
the button.
We must hide it completely, user has to use the 2 buttons from the dup
message "Editing existing" or "Save as new".

Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk>
Comment 4 Katrin Fischer 2020-03-24 10:13:28 UTC
Created attachment 101531 [details] [review]
Bug 24962: Do not display the toolbar when editing a patron and dup is found

Whe a duplicate patron is found, the toolbar to save is display without
the button.
We must hide it completely, user has to use the 2 buttons from the dup
message "Editing existing" or "Save as new".

Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 5 Katrin Fischer 2020-03-24 10:27:40 UTC
(In reply to Katrin Fischer from comment #4)
> Created attachment 101531 [details] [review] [review]
> Bug 24962: Do not display the toolbar when editing a patron and dup is found
> 
> Whe a duplicate patron is found, the toolbar to save is display without
> the button.
> We must hide it completely, user has to use the 2 buttons from the dup
> message "Editing existing" or "Save as new".
> 
> Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk>
> 
> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

Thx for the quick test Sally!
Comment 6 Martin Renvoize 2020-03-24 11:34:12 UTC
Nice work everyone!

Pushed to master for 20.05
Comment 7 Joy Nelson 2020-04-03 21:58:36 UTC
does not apply to 19.11.x branch please rebase if needed.