Bug 24988 - autorenew_checkouts should default to yes
Summary: autorenew_checkouts should default to yes
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Patrons (show other bugs)
Version: master
Hardware: All All
: P5 - low major (vote)
Assignee: Nick Clemens
QA Contact: Testopia
URL:
Keywords:
Depends on: 24476
Blocks:
  Show dependency treegraph
 
Reported: 2020-03-26 12:35 UTC by Nick Clemens
Modified: 2022-12-12 21:24 UTC (History)
8 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
20.05.00


Attachments
Bug 24988: Default to autorenew_checkouts for new patrons (1.64 KB, patch)
2020-03-26 13:39 UTC, Nick Clemens
Details | Diff | Splinter Review
Bug 24988: Default to autorenew_checkouts for new patrons (1.71 KB, patch)
2020-03-26 13:52 UTC, ByWater Sandboxes
Details | Diff | Splinter Review
Bug 24988: Default to autorenew_checkouts for new patrons (1.76 KB, patch)
2020-03-26 14:40 UTC, Devinim
Details | Diff | Splinter Review
Bug 24988: Default to autorenew_checkouts for new patrons (1.83 KB, patch)
2020-03-26 16:08 UTC, Kyle M Hall
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Nick Clemens 2020-03-26 12:35:19 UTC
TO recreate:
Create a new patron
Note that 'Allow auto-renewal of items' defaults to 'no'
This is a regression caused by bug 24476
Comment 1 Nick Clemens 2020-03-26 13:39:44 UTC
Created attachment 101836 [details] [review]
Bug 24988: Default to autorenew_checkouts for new patrons

To recreate:
1 - Create a new patron on the staff interface
2 - Note that 'Allow auto-renewal of items' defaults to 'no'
3 - Apply patch
4 - Create another patron
5 - 'Allow auto-renewal of items' defaults to 'yes'
Comment 2 ByWater Sandboxes 2020-03-26 13:52:23 UTC
Created attachment 101849 [details] [review]
Bug 24988: Default to autorenew_checkouts for new patrons

To recreate:
1 - Create a new patron on the staff interface
2 - Note that 'Allow auto-renewal of items' defaults to 'no'
3 - Apply patch
4 - Create another patron
5 - 'Allow auto-renewal of items' defaults to 'yes'

Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk>
Comment 3 Devinim 2020-03-26 14:28:51 UTC
You are faster than us Nick!
Comment 4 Devinim 2020-03-26 14:40:38 UTC
Created attachment 101863 [details] [review]
Bug 24988: Default to autorenew_checkouts for new patrons

To recreate:
1 - Create a new patron on the staff interface
2 - Note that 'Allow auto-renewal of items' defaults to 'no'
3 - Apply patch
4 - Create another patron
5 - 'Allow auto-renewal of items' defaults to 'yes'

Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk>
Signed-off-by: Devinim <kohadevinim@devinim.com.tr>
Comment 5 Kyle M Hall 2020-03-26 16:08:50 UTC
Created attachment 101888 [details] [review]
Bug 24988: Default to autorenew_checkouts for new patrons

To recreate:
1 - Create a new patron on the staff interface
2 - Note that 'Allow auto-renewal of items' defaults to 'no'
3 - Apply patch
4 - Create another patron
5 - 'Allow auto-renewal of items' defaults to 'yes'

Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk>
Signed-off-by: Devinim <kohadevinim@devinim.com.tr>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 6 Martin Renvoize 2020-03-27 08:38:49 UTC
Nice work everyone!

Pushed to master for 20.05
Comment 7 Joy Nelson 2020-04-03 22:43:34 UTC
does not apply to 19.11.x
please rebase if needed.
Comment 8 Marcel de Rooy 2021-11-29 14:05:57 UTC
I do not really understand why autorenewal should default to Yes.
Suppose that you have set Autorenewal off for all your circ rules. And now you see allow auto-renewal popping up everywhere..
This is quite confusing.
Imo we need more checks than just default to Yes.

Who opens a bug report like 'auto_renewal should not default to Yes' ?
Comment 9 Nick Clemens 2021-11-29 14:30:50 UTC
(In reply to Marcel de Rooy from comment #8)
> I do not really understand why autorenewal should default to Yes.

In this context, it is whether the patron/staff has allowed autorenewal of items for this patron. This does not affect whether an item will be marked for autorenewal when issued, but rather whether an issue marked as autorenewal will be allowed to renew. The feature allows a patron to be opted out of auto renewals and to manage renewals manually

> Suppose that you have set Autorenewal off for all your circ rules. And now
> you see allow auto-renewal popping up everywhere..

It does not popup everywhere, it shows on the patron edit screen - it originally was hideable in syspref, see bug 25029

> This is quite confusing.
> Imo we need more checks than just default to Yes.

If not defaulted to yes, then we need a way to set patrons to 'yes' if the circ rules are changed

> Who opens a bug report like 'auto_renewal should not default to Yes' ?

I guess me ;-)

Perhaps the column could be better named
Comment 10 David Cook 2021-12-01 03:47:29 UTC
(In reply to Marcel de Rooy from comment #8)
> I do not really understand why autorenewal should default to Yes.

I suspect most people would be in favour of autorenewal (I know I am as a library patron - very handy functionality), and it's more likely there would be a minority of people wanting to refuse it. Hence default to yes.

> Suppose that you have set Autorenewal off for all your circ rules. And now
> you see allow auto-renewal popping up everywhere..
> This is quite confusing.
> Imo we need more checks than just default to Yes.

As I noted on bug 24476, I don't think it's quite that simple. Even if all the autorenewals are turned off in the circ rules, you might have current checkouts that are still marked as autorenewal (which I think still get processed as autorenewals although I should double-check that), and you can choose to make an item an "Automatic renewal" by going into "Checkout settings" when checking out an item.

I do agree though that it's complicated. On the surface, it seems silly to allow a patron to control an autorenewal setting if the library doesn't actually use autorenewals, but I think they're conceptually two different things. One is marking an item as an autorenewal, and the other is the patron allowing items to be autorenewed. 

(Of course, I wonder why a patron should be able to turn off autorenewal, but I don't really like how autorenewal has been implemented overall and how it prevents manual renewals. But that's another matter...)
Comment 11 David Cook 2021-12-01 03:59:16 UTC
(In reply to Marcel de Rooy from comment #8)
> Who opens a bug report like 'auto_renewal should not default to Yes' ?

Does this seem like a productive question?
Comment 12 Marcel de Rooy 2021-12-01 12:13:55 UTC
(In reply to David Cook from comment #11)
> (In reply to Marcel de Rooy from comment #8)
> > Who opens a bug report like 'auto_renewal should not default to Yes' ?
> 
> Does this seem like a productive question?

Heh. Thats a good point :) I am glad though that Nick already picked this up!
Thanks for your feedback.
Sometimes we should save our comment on Bugzilla a day or so, and decide not to submit it?
Comment 13 David Cook 2021-12-01 22:59:20 UTC
(In reply to Marcel de Rooy from comment #12)
> Heh. Thats a good point :) I am glad though that Nick already picked this up!
> Thanks for your feedback.
> Sometimes we should save our comment on Bugzilla a day or so, and decide not
> to submit it?

Thanks for accepting the feedback, and I know that feeling well. These days, I try to sit on my own comments more, so I understand 😅.
Comment 14 Katrin Fischer 2021-12-05 22:27:00 UTC
I just got into this conversation... but why is this resolved fixed now?

The bug report made sense to me? (must be missing something here)
Comment 15 Marcel de Rooy 2021-12-06 07:07:22 UTC
(In reply to Katrin Fischer from comment #14)
> I just got into this conversation... but why is this resolved fixed now?
> 
> The bug report made sense to me? (must be missing something here)

Pushed to 20.05. See also comment8