Bug 25028 - The not-onloan-count index is not used in ES
Summary: The not-onloan-count index is not used in ES
Status: NEW
Alias: None
Product: Koha
Classification: Unclassified
Component: Searching - Elasticsearch (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal
Assignee: Bugs List
QA Contact:
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-03-31 15:13 UTC by Tomás Cohen Arazi (tcohen)
Modified: 2021-11-20 07:53 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tomás Cohen Arazi (tcohen) 2020-03-31 15:13:38 UTC 
The code in Koha::SearchEngine::Elasticsearch::QueryBuilder::_fix_limit_special_cases only sets onloan:false on the query if the availability limit is passed.

This is not (a) matching the Zebra behaviour and (b) it should be using the not-onloan-count index (which is configured) but as the indexer is feeded with the output from GerMarcBiblio as-is, it wouldn't include 999$x as the rebuild_zebra.pl counter part does, using the RecordProcessor filters.

Looking at rebuild_zebra.pl and the fact that ES doesn't use the EmbedSeeFromHeadings filter either, probably more bugs should be filled.

I'm possibly missing some more magic on the QueryParser code that could deal with this things in a different way (than Zebra). But the availability one looks plain wrong so worth filing this bug.
Comment 1 Fridolin Somers 2021-11-20 07:42:04 UTC 
> Looking at rebuild_zebra.pl and the fact that ES doesn't use the EmbedSeeFromHeadings filter either, probably more bugs should be filled.

This was fixed in Bug 25030