When trying to display older transactions in the POS module, there is an error: Template process failed: undef error - The given date (12.04.2020) does not match the date format (iso) at /home/vagrant/kohaclone/Koha/DateUtils.pm line 168. at /home/vagrant/kohaclone/C4/Templates.pm line 122 URL: http://localhost:8081/cgi-bin/koha/pos/register.pl?trange_f=07.04.2020&trange_t=12.04.2020®isterid=1 It looks like the dateformat is not handled correctly here. Dateformat is set to DD.MM.YYYY
Created attachment 102913 [details] [review] Bug 25139: Corrections to date picker handling It would appear one has to format the dates in the controller rather than in the template for input fields.. I wasn't aware of this caveat until now. Test plan 1/ Prior to applying patch attempt to look at previous transactions ensuring you enter a 'to' date. 2/ Note a catastrophic failure 3/ Apply patch 4/ Look at the same date range and note you no longer get a failure but are instead faced with the requested transactions. 5/ Signoff
Created attachment 102924 [details] [review] Bug 25139: Corrections to date picker handling It would appear one has to format the dates in the controller rather than in the template for input fields. I wasn't aware of this caveat until now. Test plan 0/ Enable cash register and POS system, add a register, items and some transactions. 1/ Prior to applying patch attempt to look at previous transactions ensuring you enter a 'to' date. 2/ Note a catastrophic failure 3/ Apply patch 4/ Look at the same date range and note you no longer get a failure but are instead faced with the requested transactions. 5/ Signoff Signed-off-by: David Nind <david@davidnind.com>
Created attachment 102949 [details] [review] Bug 25139: Corrections to date picker handling It would appear one has to format the dates in the controller rather than in the template for input fields.. I wasn't aware of this caveat until now. Test plan 1/ Prior to applying patch attempt to look at previous transactions ensuring you enter a 'to' date. 2/ Note a catastrophic failure 3/ Apply patch 4/ Look at the same date range and note you no longer get a failure but are instead faced with the requested transactions. 5/ Signoff Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Nice work everyone! Pushed to master for 20.05
does not apply to 19.11.x - not backported