Bug 25175 - Don't die on broken plugins
Summary: Don't die on broken plugins
Status: CLOSED WONTFIX
Alias: None
Product: Koha
Classification: Unclassified
Component: Plugin architecture (show other bugs)
Version: Main
Hardware: All All
: P5 - low major (vote)
Assignee: Bugs List
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-04-17 11:31 UTC by Tomás Cohen Arazi
Modified: 2020-11-30 21:44 UTC (History)
0 users

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Tomás Cohen Arazi 2020-04-17 11:31:06 UTC

    
Comment 1 Tomás Cohen Arazi 2020-04-17 11:32:40 UTC
If a plugin doesn't compile, Plack currently explodes:

1. Add use Tomas; to a sample plugin and restart plack
=> FAIL: It explodes
2. Add die "algo" to the plugin's neW() method and rstart plack
=> FAIL: It explodes
Comment 2 Tomás Cohen Arazi 2020-04-17 12:09:08 UTC
I will roll back on this one, as putting die in ->new is extreme. And missing libs and syntax errors are already cough by the call to 'load'.