Bug 2531 - Cannot delete private shelf.
Summary: Cannot delete private shelf.
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Lists (show other bugs)
Version: Main
Hardware: PC All
: PATCH-Sent (DO NOT USE) major
Assignee: Galen Charlton
QA Contact:
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-08-18 03:16 UTC by Chris Cormack
Modified: 2012-10-25 21:28 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:

Attachments
fix the opac part of the problem in 3.0.x and 3.2 (23.43 KB, patch)
2008-11-05 07:19 UTC, Chris Cormack 		Details | Diff | Splinter Review
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Cormack 2010-05-21 00:52:15 UTC 


---- Reported by joe.atzberger@liblime.com 2008-08-18 15:16:28 ----

Can't seem to delete private shelves, even if empty and user is owner.



---- Additional Comments From gmcharlt@gmail.com 2008-08-21 10:36:28 ----

OPAC?  Staff?  Anyway, assigning to Chris.



---- Additional Comments From joe.atzberger@liblime.com 2008-08-21 11:24:48 ----

Both OPAC and Staff.

OPAC gives: "ERROR: List number 118 unrecognized."

Staff just doesn't do anything.



---- Additional Comments From nahuel.angelinetti@biblibre.com 2008-11-05 07:19:51 ----

Created an attachment
fix the opac part of the problem in 3.0.x and 3.2





---- Additional Comments From gmcharlt@gmail.com 2008-11-06 13:08:26 ----

Nahuel's patch pushed, but note that it only solves part of the problem.  It doesn't fix the following scenarios:

[1] Create a new private list in the OPAC, then immediately delete it.
[2] Try to delete a private list in the staff client.

As this bug had been assigned to Allen before Nahuel submitted a patch to it, I invite Allen to follow up with fixes for the rest.



---- Additional Comments From allen.reinmeyer@liblime.com 2008-11-17 18:02:22 ----

Patch sent.  

Use cases tested:
staff/OPAC side:
--delete list right after creation (private/public)
--delete list after viewing (private/public populated/empty)
--delete list from manage shelfs page (public/private populated/empty)






---- Additional Comments From gmcharlt@gmail.com 2008-11-20 16:14:48 ----

Allen's patch pushed to 3.1.  Please test and close.



--- Bug imported by chris@bigballofwax.co.nz 2010-05-21 00:52 UTC  ---

This bug was previously known as _bug_ 2531 at http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=2531
Imported an attachment (id=714)

Actual time not defined. Setting to 0.0
The original reporter of this bug does not have
   an account here. Reassigning to the person who moved
   it here: chris@bigballofwax.co.nz.
   Previous reporter was joe.atzberger@liblime.com.
The original assignee of this bug does not have
   an account here. Reassigning to the default assignee
   for the component, gmcharlt@gmail.com.
   Previous assignee was allen.reinmeyer@liblime.com.
The original submitter of attachment 714 [details] [review] is unknown.
   Reassigning to the person who moved it here: chris@bigballofwax.co.nz.