Bug 25338 - Koha checks items in when lost fee waived/paid
Summary: Koha checks items in when lost fee waived/paid
Status: NEW
Alias: None
Product: Koha
Classification: Unclassified
Component: Fines and fees (show other bugs)
Version: 19.05
Hardware: All All
: P5 - low normal (vote)
Assignee: Bugs List
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-04-30 21:27 UTC by Christopher Brannon
Modified: 2024-01-01 12:43 UTC (History)
1 user (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Christopher Brannon 2020-04-30 21:27:08 UTC
To replicate:

1) Check out an item to patron and have item go lost and charge for item.
2) Renew item.  Notice status is not changed.  Fee is not removed.
3) Remove lost status.  Notice fee is not removed.  Item remains on patron account.
4) Waive or pay fee.  Notice the item is checked!

What the heck!

There are a few things wrong here.  First, if an item is renewed, the lost status should at least be removed.  Maybe there needs to be a setting for this, and whether or not the fee is removed if the item is renewed.

Second, if you remove the lost item status, the fee remains.  Again, maybe there needs to be a setting for that to decide if the fee should be remove.

Third, and this is THE BIGGEST ISSUE I have with this.  Under no circumstances should waiving or paying for a fee change the status of the item from checked out to checked in.  Maybe there should be an option, but I can't think of a good reason for this to happen, ever.

Would like to have a quick fix for this last issue, ASAP, especially since we had extended due dates with the new batch tool due to COVID-19, and we are going to be correcting a lot of these.  Currently, the ONLY workaround I've seen is that I have to watch the item after waiving the fee, and check it back out to the patron.  This is a good way to lose track of items that are out, and very easy for someone to miss.  Because of that, I am marking this as critical.
Comment 1 Jonathan Druart 2020-05-13 14:00:07 UTC
Hi Christopher, can you detail THE BIGGEST ISSUE please? I guess you have  MarkLostItemsAsReturned that is empty.
How do you "Waive or pay fee"? I don't manage to recreate the checkin problem on master.
Comment 2 Christopher Brannon 2020-05-14 14:14:46 UTC
(In reply to Jonathan Druart from comment #1)
> Hi Christopher, can you detail THE BIGGEST ISSUE please?

This is THE BIGGEST ISSUE I have with this: under no circumstances should waiving or paying for a fee change the status of the item from checked out to checked in.

> I guess you have MarkLostItemsAsReturned that is empty.

No.  It reads: Mark items as returned when flagged as lost from the items tab of the catalog module.

> How do you "Waive or pay fee"?

Go to the accounts for the patron and waive or pay the fee for the lost item.  I'm not sure what else to say.  That is pretty straight forward.

> I don't manage to recreate the checkin problem on master.

I don't know what to tell you.  It is happening here under 19.5.
Comment 3 Jonathan Druart 2020-05-14 14:22:38 UTC
I tried yesterday but failed. There are several ways of paying a fine.
Which exact version of 19.05?
Comment 4 Christopher Brannon 2020-05-15 14:13:50 UTC
(In reply to Jonathan Druart from comment #3)
> I tried yesterday but failed. There are several ways of paying a fine.
> Which exact version of 19.05?

19.5.9

There may be several ways, but I gave the specific way we did it.
Comment 5 Jonathan Druart 2020-05-18 10:12:37 UTC
On 19.05.09

0. Set  MarkLostItemsAsReturned = "from the items tab of the catalog module"
Other values are all default from sample data.
1. update itemtypes set processfee=5; # Charge 5 when lost
2. Check out
3. Mark the item as lost (cataloguing)
4. Item is still checked out and charge has been created ("Fees & Charges: Patron has outstanding fees & charges of 5.00.")
-. [not needed] Renew the item: no change
5. Remove lost status
6. Pay the fees, "Make a payment" > "Pay" button on the line of the fee > "Pay an individual fine" > Ok
https://snipboard.io/G9ULXr.jpg

7. Item is not checked in
https://snipboard.io/LbU4Pj.jpg
Comment 6 Jonathan Druart 2020-05-19 08:51:53 UTC
Lowering severity until it is confirmed.
Comment 7 Katrin Fischer 2020-05-22 11:55:36 UTC
I can see that there is a new option in MarkLostItemsAsReturned - "when receiving payment for the item". I think this could fit the behaviour here and points to:

Bug 24474 - Lost items that are checked out are always returned, even when attempting to renew them 

But it appears this will only be available in 20.05. If that fits the problem description, one could make a case for rebase and backport maybe.
Comment 8 Christopher Brannon 2020-05-22 14:57:22 UTC
(In reply to Jonathan Druart from comment #5)
> On 19.05.09


https://streamable.com/ojdgw8
Comment 9 Katrin Fischer 2024-01-01 12:43:59 UTC
Christopher, could you confirm bug 24474 fixed this in later versions?