Bug 25472 - Invalid overdue action trigger should cause a warning or error instead of being ignored
Summary: Invalid overdue action trigger should cause a warning or error instead of bei...
Status: NEW
Alias: None
Product: Koha
Classification: Unclassified
Component: Notices (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Bugs List
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-05-12 22:20 UTC by Victor Grousset/tuxayo
Modified: 2020-05-23 11:37 UTC (History)
0 users

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Victor Grousset/tuxayo 2020-05-12 22:20:25 UTC
== Invalidity case 1 ==
misc/cronjobs/overdue_notices.pl
just silently does nothing when "Restrict" ticked and nothing else in the same trigger. A notification must be also enabled for the restriction to happen.

== Invalidity case 2 ==
If "Letter" is set to "No notice" , then when "Email" is ticked, it's also silently ignored.


The user should know about the trigger invalidity in the above two case to cause less guesswork when restriction aren't done or notifications not sent.
Could be in the UI, could be the cron job that errors.
Comment 1 Katrin Fischer 2020-05-23 11:37:03 UTC
I think this is somewhat similar to the issues reported on bug 25049 - more validation is needed.